wait for write loop to finish at end of ruby read loop, on client side calls#8833
Merged
apolcyn merged 1 commit intogrpc:v1.0.xfrom Nov 29, 2016
Merged
Conversation
murgatroid99
approved these changes
Nov 23, 2016
Contributor
Author
|
failures look unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safe shutdowns at the ends of ruby benchmarks rely on all client side calls finishing before shutting down the server. But currently, joining the client side streaming call threads doesn't guarantee that the calls are done, as the spawned write loop finishes on its own time.