Re-enable Node 7 artifact build#8818
Merged
murgatroid99 merged 1 commit intogrpc:v1.0.xfrom Nov 28, 2016
Merged
Conversation
apolcyn
approved these changes
Nov 22, 2016
Contributor
apolcyn
left a comment
apolcyn
left a comment
There was a problem hiding this comment.
It seems like this is working now without other changes since it was last disabled?
Otherwise LGTM
Member
Author
|
Actually, this still doesn't work yet. |
Member
Author
|
And now it works. The updated version of node-pre-gyp has been published. Successful build: https://grpc-testing.appspot.com/view/Artifacts/job/gRPC_build_artifacts/2262/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 7 has been out long enough that our build should support it without any issues. People are asking for this, so we should definitely have it in the next release.