Objective-C: Fix memory leak of every message sent#8790
Objective-C: Fix memory leak of every message sent#8790jcanizales merged 1 commit intogrpc:masterfrom
Conversation
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
|
this is ok to test |
|
cc @jcanizales |
|
|
||
| - (void)dealloc { | ||
| gpr_free(_op.data.send_message); | ||
| grpc_slice_buffer_destroy(_op.data.send_message); |
There was a problem hiding this comment.
_op.data.send_message needs to be a grpc_byte_buffer. Looking at its definition, the slice buffer is encapsulated within it. So I assume grpc_byte_buffer_destroy will take care of it, and is the right choice here.
There was a problem hiding this comment.
Yup. Fixed and rebased on current master.
…aks reference counted backing slices.
pquerna
force-pushed
the
objc_fix_leak_of_buffer
branch
from
75341ba to
d907370
Compare
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
Description: Adds serialization method to filter state and use from logger if specified. Risk Level: Low Testing: CI Docs Changes: Added Release Notes: Added Fixes grpc#8790 Signed-off-by: Lizan Zhou <[email protected]> Mirrored from https://github.com/envoyproxy/envoy @ cf74f816933d1350d7c588a3b8478dd399ce3d18
8 participants
GPR Buffers need to be destroyed, not directly freed, otherwise it leaks the reference counted backing slices.
Hard to validate for me on macOS right now due to #8766