Make initial connect retry backoff configurable#8235
Merged
nicolasnoble merged 7 commits intogrpc:masterfrom Sep 29, 2016
Merged
Make initial connect retry backoff configurable#8235nicolasnoble merged 7 commits intogrpc:masterfrom
nicolasnoble merged 7 commits intogrpc:masterfrom
Conversation
dgquintas
suggested changes
Sep 28, 2016
| } else if (0 == strcmp(c->args->args[i].key, | ||
| GRPC_ARG_INITIAL_RECONNECT_BACKOFF_MS)) { | ||
| fixed_reconnect_backoff = false; | ||
| max_backoff_ms = grpc_channel_arg_get_integer( |
Contributor
There was a problem hiding this comment.
s/max_backoff_ms/initial_backoff_ms
dgquintas
approved these changes
Sep 28, 2016
Set initial backoff to 10000ms when creating channel in Objective C
Member
Author
|
@makdharma @jcanizales - PTAL at the ObjC changes |
jcanizales
suggested changes
Sep 29, 2016
Contributor
jcanizales
left a comment
jcanizales
left a comment
There was a problem hiding this comment.
I would add a comment that this is required for correct behavior on slow networks. Otherwise people of the future with their super beefy Mac Jenkins slaves could think it's fine to remove.
| args[@GRPC_ARG_MAX_RECEIVE_MESSAGE_LENGTH] = _responseSizeLimitOverride; | ||
| } | ||
| NSNumber *initialBackoff = [NSNumber numberWithInt:10000]; | ||
| args[@GRPC_ARG_INITIAL_RECONNECT_BACKOFF_MS] = initialBackoff; |
Contributor
There was a problem hiding this comment.
I think = @10000; will give you the NSNumber.
Contributor
There was a problem hiding this comment.
Interesting feature :) I'll clean up
Member
Author
|
@muxi - hoping you can respond to @jcanizales requests |
Contributor
|
Please merge the other PR referenced above |
Clean up code
Member
Author
|
Changes merged - @jcanizales PTAL |
jcanizales
approved these changes
Sep 29, 2016
Contributor
|
Regenerate projects plz. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.