Skip to content

Add a GrpcEnvironment.NativeLibrary property as an escape hatch for unusual deployment scenarios#7303

Closed
jskeet wants to merge 1 commit intogrpc:masterfrom
jskeet:custom-loading
Closed

Add a GrpcEnvironment.NativeLibrary property as an escape hatch for unusual deployment scenarios#7303
jskeet wants to merge 1 commit intogrpc:masterfrom
jskeet:custom-loading

Conversation

@jskeet
Copy link
Copy Markdown
Contributor

@jskeet jskeet commented Jul 11, 2016

Basically this is for cases where the auto-detection would fail.
This API is marked as being experimental.

(The PR has been split off from #7282.)

…nusual deployment scenarios

Basically this is for cases where the auto-detection would fail.
This API is marked as being experimental.
@grpc-kokoro
Copy link
Copy Markdown
Collaborator

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

3 similar comments
@grpc-kokoro
Copy link
Copy Markdown
Collaborator

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

@grpc-kokoro
Copy link
Copy Markdown
Collaborator

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

@grpc-kokoro
Copy link
Copy Markdown
Collaborator

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

jskeet added a commit to jskeet/grpc that referenced this pull request Jul 12, 2016
@grpc-kokoro
Copy link
Copy Markdown
Collaborator

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

6 similar comments
@grpc-kokoro
Copy link
Copy Markdown
Collaborator

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-kokoro
Copy link
Copy Markdown
Collaborator

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-kokoro
Copy link
Copy Markdown
Collaborator

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-kokoro
Copy link
Copy Markdown
Collaborator

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-kokoro
Copy link
Copy Markdown
Collaborator

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-kokoro
Copy link
Copy Markdown
Collaborator

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@jtattermusch
Copy link
Copy Markdown
Contributor

Jon, do you want to follow up on this one or shall we close it?

@jskeet
Copy link
Copy Markdown
Contributor Author

jskeet commented Oct 5, 2016

I still think it would be a good idea, but we could certainly punt on it for now.

@jskeet jskeet closed this Oct 5, 2016
@zaneclaes
Copy link
Copy Markdown

@jskeet @jtattermusch could this be revisited? The TODO in LoadUnmanagedLibrary has been sitting in the code for a long time, and I find the lack of configurability to be a major annoyance in working with GRPC. I'd be happy with just a one-line change to add an optional environment variable override for the path.

@jskeet
Copy link
Copy Markdown
Contributor Author

jskeet commented Aug 3, 2018

Definitely up to @jtattermusch - it feels reasonable to me too, but I don't have nearly as much experience as Jan on this.

@jtattermusch
Copy link
Copy Markdown
Contributor

@zaneclaes I can try to revive this PR (I expect to run into some merge conflicts some of which might be interesting to solve) but not sure when I'll get to it. Feel free to recreate the PR yourself if this is a feature you need.

@jtattermusch
Copy link
Copy Markdown
Contributor

@zaneclaes do you have particular loading scenarios/platforms in mind? The way the loading of native library works has actually recently become more complicated as we added Unity and Xamarin support.
The new mobile platforms actually rely purely on [DllImport] annotated methods and they don't use the logic for explicit loading of the library from a disk file:

So, after re-thinking, setting the native library path would only work on some platforms (~ the "desktop" ones) while on others I can't think of a way how to implement this new setting.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants