Skip to content

Remove caching of results by run_tests#7027

Merged
jtattermusch merged 6 commits intogrpc:masterfrom
ctiller:faster_runtests
Jun 27, 2016
Merged

Remove caching of results by run_tests#7027
jtattermusch merged 6 commits intogrpc:masterfrom
ctiller:faster_runtests

Conversation

@ctiller
Copy link
Copy Markdown
Member

@ctiller ctiller commented Jun 23, 2016

SIGNIFICANTLY increases the performance of actually running tests...

also saves burning a core per run_tests while it figures out hashes of c core binaries

SIGNIFICANTLY increases the performance of actually running tests...
@jtattermusch
Copy link
Copy Markdown
Contributor

LGTM, let's see what the tests say.

@jtattermusch
Copy link
Copy Markdown
Contributor

Traceback (most recent call last):
  File "tools/run_tests/run_interop_tests.py", line 722, in <module>
    job = dockerjob.DockerJob(spec)
  File "/home/jenkins/workspace/gRPC_interop_pull_requests/grpc/tools/run_tests/dockerjob.py", line 107, in __init__
    self._job = jobset.Job(spec, bin_hash=None, newline_on_success=True, travis=True, add_env={})
TypeError: __init__() got an unexpected keyword argument 'bin_hash'

@jtattermusch
Copy link
Copy Markdown
Contributor

looks like grepping other python files might be useful.

@jtattermusch
Copy link
Copy Markdown
Contributor

breaks python tests:

Traceback (most recent call last):
  File "tools/run_tests/run_tests.py", line 1272, in <module>
    build_only=args.build_only)
  File "tools/run_tests/run_tests.py", line 1196, in _build_and_run
    for language in languages
  File "tools/run_tests/run_tests.py", line 1197, in <genexpr>
    for spec in language.test_specs()
  File "tools/run_tests/run_tests.py", line 399, in test_specs
    for tox_env in self._tox_envs]
TypeError: job_spec() got multiple values for keyword argument 'timeout_seconds'
  adding: reports/ (stored 0%)
  adding: reports/index.html (deflated 22%)

zip error: Nothing to do! (reports.zip)
+ DOCKER_FAILED=true

@ctiller
Copy link
Copy Markdown
Member Author

ctiller commented Jun 27, 2016

Think I resolved the Python thing, the rest seems to be infrastructural.

@jtattermusch jtattermusch merged commit 0c75c11 into grpc:master Jun 27, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants