Fix accept_stream being called post-channel deletion#5560
Merged
vjpai merged 5 commits intogrpc:masterfrom Mar 4, 2016
Merged
Conversation
- Have the server clear the accept_stream callback prior to destroying the channel (required a small transport op protocol change) - Have the transport not enact transport ops until parsing is completed (prevents accept_stream from disappearing mid-parse)
src/core/transport/transport.h
Outdated
| @@ -139,8 +139,10 @@ typedef struct grpc_transport_op { | |||
| gpr_slice *goaway_message; | |||
| /** set the callback for accepting new streams; | |||
| this is a permanent callback, unlike the other one-shot closures */ | |||
Contributor
There was a problem hiding this comment.
the docstring seems misplaced with the introduction of the boolean guard (which isn't mentioned).
Member
Author
|
Updated documentation. Refined post-parse conditional to something that I know is safe. |
Contributor
|
LGTM after the changes. Will merge. |
vjpai
added a commit
that referenced
this pull request
Mar 4, 2016
Fix accept_stream being called post-channel deletion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the channel (required a small transport op protocol change)
(prevents accept_stream from disappearing mid-parse)