LGTM.

1. Sorry for the delay. Do you want to rebase on master because it has been so long? - totally my fault for not getting back to this sooner.
2. Do you want to keep the old examples/node/greeter_client.js and examples/node/greeter_server.js? I think keeping the old example with the dynamic stuff will be useful.

Tested:

• installing the grpc_node_plugin
• generating two .js files per .proto via the protoc --js_out command
• installing the google-protobuf npm module
• running the new static codegen helloworld example

Notes for future references:

• installed node 4.x, protobuf pre-reqs like autoconf, automake, libtool, etc, and java
• cloned protobuf github source, master branch
• cloned grpc github source, this PR branch
• compiled and installed protoc from source (master branch)
• compiled and installed grpc from source (this PR branch), mostly for the node protoc plugin
• ran protoc to generate two .js stub files per .proto: protoc --js_out=import_style=commonjs,binary:. --grpc_out=. --plugin=protoc-gen-grpc=/usr/local/bin/grpc_node_plugin helloworld.proto
• need to do npm install and gulp dist from the ~/protobuf/js source directory to generate the google-protobuf.js main file
• in grpc/examples/node, need to npm install ../../../protobuf/js to install the google-protobuf npm module from source
• in grpc/examples/node, run nodejs greeter_server.js and nodejs greeter_client.js

I tried to run this against math.proto but I got an error when I run a client:

/home/stanleycheung/grpc/src/node/test/math_grpc_pb.js:54
    requestSerialize: serialize_FibArgs,
                      ^
ReferenceError: serialize_FibArgs is not defined
    at Object.<anonymous> (/home/stanleycheung/grpc/src/node/test/math_grpc_pb.js:54:23)

I looked at the generated math_grpc_pb.js, the serialize_FibArgs function is indeed missing, as with any xxxx_FibArgs functions actually. There are only 2 functions (serialize/deserialize) each for the DivArgs and DivReply message, none for the FibArgs, Num nor FibReply message.

I used this command to generate the .js code as before: protoc --js_out=import_style=commonjs,binary:. --grpc_out=. --plugin=protoc-gen-grpc=/usr/local/bin/grpc_node_plugin math.proto

I fixed that problem. It was a simple loop variable bug. I also rewrote the test math client and server to test the generated code (in addition to what they were already doing).

LGTM, and verified. Re-tested the codegen part, and the math_client_test.js script. Thanks for the fix.

Tested the latest commit as well. LGTM. Yes I did have to hack the generated code a bit to import grpc directly before and now I don't.

The Node tests are finally passing

Nice!