Skip to content

Doc Fixit: Update base INSTALL to markdown and remove outdated content#5272

Merged
stanley-cheung merged 2 commits intogrpc:release-0_13from
stanley-cheung:update_install_doc
Mar 3, 2016
Merged

Doc Fixit: Update base INSTALL to markdown and remove outdated content#5272
stanley-cheung merged 2 commits intogrpc:release-0_13from
stanley-cheung:update_install_doc

Conversation

@stanley-cheung
Copy link
Copy Markdown
Contributor

@stanley-cheung stanley-cheung commented Feb 17, 2016

Fixes #5243

@stanley-cheung stanley-cheung self-assigned this Feb 17, 2016
@stanley-cheung stanley-cheung added this to the 2016/02/15 Milestone milestone Feb 17, 2016
@grpc-kokoro
Copy link
Copy Markdown
Collaborator

grpc-kokoro commented Feb 17, 2016

Can one of the admins verify this patch?

1 similar comment
@grpc-kokoro
Copy link
Copy Markdown
Collaborator

grpc-kokoro commented Feb 17, 2016

Can one of the admins verify this patch?

@jcanizales
Copy link
Copy Markdown
Contributor

jcanizales commented Feb 18, 2016

Fixes #5221.

@jcanizales
Copy link
Copy Markdown
Contributor

jcanizales commented Feb 18, 2016

Fixes #5218 too, I presume.

@stanley-cheung
Copy link
Copy Markdown
Contributor Author

stanley-cheung commented Feb 18, 2016

@hsaliak @zinuga Please give me some feedback on this so we can iterate?

jcanizales
jcanizales reviewed Feb 18, 2016
View reviewed changes
INSTALL.md Outdated
Copy link
Copy Markdown
Contributor

@jcanizales jcanizales Feb 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure this is installing 0.13. @murgatroid99 do you know?

Copy link
Copy Markdown
Member

@murgatroid99 murgatroid99 Feb 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you follow that link, it just goes to the latest version of https://github.com/grpc/homebrew-grpc/blob/master/scripts/install

Copy link
Copy Markdown
Contributor

@jcanizales jcanizales Feb 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so 0.11 then, it seems :S

Copy link
Copy Markdown
Contributor Author

@stanley-cheung stanley-cheung Feb 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After 0.13 got released we can easily update the homebrew formula.

Copy link
Copy Markdown
Contributor

@hsaliak hsaliak Feb 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should direct users to language specific packages if that's what they are actually interested in.
If you are in a Hurry and only want to install gRPC as a dependency, follow language specific instructions.
For the C core, this can be accomplished by doing the following.
Windows
Linux
Mac OSX..

@jcanizales
Copy link
Copy Markdown
Contributor

jcanizales commented Feb 25, 2016

This also fixes #5379.

@stanley-cheung stanley-cheung force-pushed the update_install_doc branch 2 times, most recently from b29443d to cc85447 Compare March 3, 2016 00:46
@stanley-cheung stanley-cheung changed the title Update base INSTALL to markdown and remove outdated content Doc Fixit: Update base INSTALL to markdown and remove outdated content Mar 3, 2016
@stanley-cheung
Copy link
Copy Markdown
Contributor Author

stanley-cheung commented Mar 3, 2016

@hsaliak reviewed this offline with me. Merging as it's doc only change.

stanley-cheung added a commit that referenced this pull request Mar 3, 2016
@stanley-cheung
Merge pull request #5272 from stanley-cheung/update_install_doc
1556377 
Doc Fixit: Update base INSTALL to markdown and remove outdated content
@stanley-cheung stanley-cheung merged commit 1556377 into grpc:release-0_13 Mar 3, 2016
@stanley-cheung stanley-cheung deleted the update_install_doc branch March 3, 2016 22:51
@stanley-cheung stanley-cheung mentioned this pull request Mar 3, 2016
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@hsaliak hsaliak

Labels

area/documentation cla: yes

Projects

None yet

Milestone

2016/04/01 Milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@stanley-cheung @grpc-kokoro @jcanizales @hsaliak @murgatroid99 @ctiller @googlebot