[xDS unit test] remove need for grpc_cc_proto_library BUILD rule#37902
Closed
markdroth wants to merge 14 commits intogrpc:masterfrom
Closed
[xDS unit test] remove need for grpc_cc_proto_library BUILD rule#37902markdroth wants to merge 14 commits intogrpc:masterfrom
grpc_cc_proto_library BUILD rule#37902markdroth wants to merge 14 commits intogrpc:masterfrom
Conversation
markdroth
added
the
release notes: no
grpc-checks
bot
added
bloat/none
per-call-memory/neutral
per-channel-memory/neutral
labels
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/neutral
labels
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/decrease
labels
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/increase
labels
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/neutral
labels
markdroth
changed the title
grpc_cc_proto_library BUILD rule
eugeneo
approved these changes
Oct 14, 2024
eugeneo
reviewed
Oct 14, 2024
| third_party/opentelemetry-cpp 4bd64c9a336fd438d6c4c9dad2e6b61b0585311f | ||
| third_party/protobuf 10ef3f77683f77fb3c059bf47725c27b3ff41e63 | ||
| third_party/protoc-gen-validate fab737efbb4b4d03e7c771393708f75594b121e4 | ||
| third_party/protoc-gen-validate 32c2415389a3538082507ae537e7edd9578c64ed |
Contributor
There was a problem hiding this comment.
This is remove above, should it be gone from here as well?
Member
Author
There was a problem hiding this comment.
It wasn't removed, it was upgraded to a new version.
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/decrease
labels
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Nov 25, 2024
…rpc#37902) This eliminates the need for the `grpc_cc_proto_library` bazel BUILD rule introduced in grpc#37863. To make this work, I had to upgrade several bazel dependencies and apply a patch to rules_go to work around bazelbuild/bazel#11636. Closes grpc#37902 PiperOrigin-RevId: 685868647
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This eliminates the need for the
grpc_cc_proto_librarybazel BUILD rule introduced in #37863.To make this work, I had to upgrade several bazel dependencies and apply a patch to rules_go to work around bazelbuild/bazel#11636.