[xds_client_test] use real xDS protos instead of local copies#37863
Closed
markdroth wants to merge 9 commits intogrpc:masterfrom
Closed
[xds_client_test] use real xDS protos instead of local copies#37863markdroth wants to merge 9 commits intogrpc:masterfrom
markdroth wants to merge 9 commits intogrpc:masterfrom
Conversation
markdroth
added
the
release notes: no
grpc-checks
bot
added
bloat/none
per-call-memory/neutral
per-channel-memory/neutral
labels
eugeneo
approved these changes
Oct 7, 2024
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/neutral
labels
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/decrease
labels
grpc-checks
bot
added
per-call-memory/decrease
per-call-memory/neutral
and removed
per-call-memory/neutral
per-call-memory/decrease
labels
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/neutral
labels
This was referenced Oct 11, 2024
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 14, 2024
…37902) This eliminates the need for the `grpc_cc_proto_library` bazel BUILD rule introduced in #37863. To make this work, I had to upgrade several bazel dependencies and apply a patch to rules_go to work around bazelbuild/bazel#11636. Closes #37902 PiperOrigin-RevId: 685868647
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Nov 25, 2024
…7863) This is a trial baloon to see if we can actually make this work. If it does, I'll change the remaining xDS tests to use the real xDS protos and completely remove our local copies. Closes grpc#37863 COPYBARA_INTEGRATE_REVIEW=grpc#37863 from markdroth:xds_tests_use_real_protos 3ad2fe1 PiperOrigin-RevId: 684877750
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Nov 25, 2024
…rpc#37902) This eliminates the need for the `grpc_cc_proto_library` bazel BUILD rule introduced in grpc#37863. To make this work, I had to upgrade several bazel dependencies and apply a patch to rules_go to work around bazelbuild/bazel#11636. Closes grpc#37902 PiperOrigin-RevId: 685868647
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a trial baloon to see if we can actually make this work. If it does, I'll change the remaining xDS tests to use the real xDS protos and completely remove our local copies.