[ConfigFetcherWatcher] Redesign interfaces between Server and Listener#37601
Closed
yashykt wants to merge 61 commits intogrpc:masterfrom
Closed
[ConfigFetcherWatcher] Redesign interfaces between Server and Listener#37601yashykt wants to merge 61 commits intogrpc:masterfrom
yashykt wants to merge 61 commits intogrpc:masterfrom
Conversation
grpc-checks
bot
added
bloat/low
per-call-memory/decrease
per-channel-memory/decrease
labels
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/increase
and removed
per-call-memory/decrease
per-channel-memory/decrease
labels
…rInterface to move the ServerConfigFetcher implementation outside chttp2
yashykt
force-pushed
the
LogicalConnection
branch
from
03060f1 to
29b7808
Compare
yashykt
added
the
release notes: no
yashykt
changed the title
grpc-checks
bot
added
per-channel-memory/neutral
and removed
per-channel-memory/increase
labels
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/neutral
labels
markdroth
reviewed
Sep 6, 2024
Member
markdroth
left a comment
markdroth
left a comment
There was a problem hiding this comment.
This looks like the right direction!
Most of my comments are small things, but there are a couple of structural ones. In particular, see my comment about using different objects for the ListenerInterface that is implemented by transports and the connection tracking done in the server code.
One other question: Is there a reasonable way to put this behind an experiment? I'm not sure how hard it is to do that, given the number of interfaces that are being changed here, but it will certainly be a lower-risk change if there's a way to do that.
Please let me know if you have any questions. Thanks!
src/core/ext/transport/chaotic_good/server/chaotic_good_server.cc
Outdated
Show resolved
Hide resolved
grpc-checks
bot
added
per-call-memory/increase
per-call-memory/decrease
and removed
per-call-memory/neutral
per-call-memory/increase
labels
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/decrease
labels
ctiller
approved these changes
Jan 6, 2025
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/neutral
labels
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/decrease
labels
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/neutral
labels
pawbhard
pushed a commit
to pawbhard/grpc
that referenced
this pull request
Jan 9, 2025
grpc#37601) <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#37601 COPYBARA_INTEGRATE_REVIEW=grpc#37601 from yashykt:LogicalConnection 50aacc3 PiperOrigin-RevId: 713079761
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Feb 20, 2025
grpc#37601) <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#37601 COPYBARA_INTEGRATE_REVIEW=grpc#37601 from yashykt:LogicalConnection 50aacc3 PiperOrigin-RevId: 713079761
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.