[Build] Apply _spawn_patch.py to grpcio_tools#37074
Closed
veblush wants to merge 1 commit intogrpc:masterfrom
Closed
[Build] Apply _spawn_patch.py to grpcio_tools#37074veblush wants to merge 1 commit intogrpc:masterfrom
veblush wants to merge 1 commit intogrpc:masterfrom
Conversation
XuanWang-Amos
approved these changes
Jun 27, 2024
Contributor
XuanWang-Amos
left a comment
There was a problem hiding this comment.
LGTM, thanks for working on this!
alto-ruby
added a commit
to alto-ruby/grpc
that referenced
this pull request
Jul 11, 2024
This reverts commit 2fc3847.
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Nov 25, 2024
grpcio_tool now needs `_spawn_patch.py` to workaround the length limit of commandline on Windows. This is a prerequisite for grpc#36753. Closes grpc#37074 COPYBARA_INTEGRATE_REVIEW=grpc#37074 from veblush:grpcio_build 9ba7b44 PiperOrigin-RevId: 647405460
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grpcio_tool now needs
_spawn_patch.pyto workaround the length limit of commandline on Windows. This is a prerequisite for #36753.