Various cosmetic improvements to run_tests.py#37
Merged
ctiller merged 3 commits intogrpc:masterfrom Jan 15, 2015
nicolasnoble:tweaks
Merged
Various cosmetic improvements to run_tests.py#37ctiller merged 3 commits intogrpc:masterfrom nicolasnoble:tweaks
ctiller merged 3 commits intogrpc:masterfrom
nicolasnoble:tweaks
Conversation
-) Adding a new command line flag to be able to see which tests are passing. -) Adding more status when the tool is idle in forever mode. -) Adding a last status when the tool is finished so to avoid leaving the console in a weird state. -) Adding a status message in the forever mode if the previous run failed. -) Swapped the message and its explanation, so you don't have to scroll up to see which test failed. -) Fixed a race condition in the watch_dir.py code if a file is deleted during the loop.
tools/run_tests/jobset.py
Outdated
Conflicts: tools/run_tests/run_tests.py
tools/run_tests/run_tests.py
Outdated
-) Fixing long line length. -) Changed the logic of the exit message.
ctiller
added a commit
that referenced
this pull request
Jan 15, 2015
Various cosmetic improvements to run_tests.py
stanley-cheung
referenced
this pull request
in stanley-cheung/grpc
Aug 27, 2015
Improving user experience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-) Adding a new command line flag to be able to see which tests are passing.
-) Adding more status when the tool is idle in forever mode.
-) Adding a last status when the tool is finished so to avoid leaving the console in a weird state.
-) Adding a status message in the forever mode if the previous run failed.
-) Swapped the message and its explanation, so you don't have to scroll up to see which test failed.
-) Fixed a race condition in the watch_dir.py code if a file is deleted during the loop.