Skip to content

[Build] Fix for gcc-9#36839

Merged
yashykt merged 4 commits intogrpc:v1.64.xfrom
yashykt:FixForGcc9
Jun 7, 2024
Merged

[Build] Fix for gcc-9#36839
yashykt merged 4 commits intogrpc:v1.64.xfrom
yashykt:FixForGcc9

Conversation

@yashykt
Copy link
Copy Markdown
Member

@yashykt yashykt commented Jun 6, 2024 •
edited
Loading

1.64.x doesn't build with gcc-9. This PR "fixes" it crashing at the offending site. This is fine since this code is not used yet.

This is a strange one since we have CI tests with gcc-7 and gcc-12, but gcc-9 has thrown errors. We are considering add builds for intermediate versions, but we do not have infinite testing resources either, so it's a bit of a balancing act.

Step #2: external/com_github_grpc_grpc/src/core/lib/surface/call.cc: In constructor 'grpc_core::{anonymous}::MaybeOpImpl<SetupFn>::MaybeOpImpl(grpc_core::{anonymous}::MaybeOpImpl<SetupFn>&&) [with SetupFn = grpc_core::ServerCallSpine::CommitBatch(const grpc_op*, size_t, void*, bool)::<lambda(const grpc_op&)>]':
Step #2: external/com_github_grpc_grpc/src/core/lib/surface/call.cc:3736:55: internal compiler error: in assign_temp, at function.c:982
Step #2:  3736 |       : state_(MoveState(other.state_)), op_(other.op_) {}
Step #2:       |

@yashykt yashykt requested a review from veblush June 6, 2024 20:50
@yashykt yashykt added the release notes: no Indicates if PR should not be in release notes label Jun 6, 2024
@yashykt yashykt requested a review from gnossen as a code owner June 7, 2024 00:37
@yashykt yashykt merged commit 6fc4a3b into grpc:v1.64.x Jun 7, 2024
@yashykt yashykt deleted the FixForGcc9 branch June 7, 2024 17:14
@yashykt yashykt added release notes: yes Indicates if PR needs to be in release notes and removed release notes: no Indicates if PR should not be in release notes labels Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnossen gnossen Awaiting requested review from gnossen gnossen is a code owner

1 more reviewer

@veblush veblush veblush approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bloat/improvement lang/c++ lang/core per-call-memory/increase per-channel-memory/neutral release notes: yes Indicates if PR needs to be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yashykt @veblush