Skip to content

Php weak comparison removal#346

Merged
tbetbetbe merged 3 commits intogrpc:masterfrom
murgatroid99:php_weak_comparison
Feb 3, 2015
Merged

Php weak comparison removal#346
tbetbetbe merged 3 commits intogrpc:masterfrom
murgatroid99:php_weak_comparison

Conversation

@murgatroid99
Copy link
Copy Markdown
Member

Removed all instances of == and !=, and assertEquals, which internally uses those, from all PHP files. This closes #338, and incidentally closes #312.

tbetbetbe added a commit that referenced this pull request Feb 3, 2015
@tbetbetbe tbetbetbe merged commit 9068b55 into grpc:master Feb 3, 2015
@tbetbetbe tbetbetbe deleted the php_weak_comparison branch February 3, 2015 18:27
@lock lock bot locked as resolved and limited conversation to collaborators Feb 2, 2019
@lock lock bot unassigned tbetbetbe Feb 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove all instances of weak comparison from PHP files Fix PHP interop client receiving null for empty_unary

2 participants