Skip to content

New C layer invoke API#34

Merged
yang-g merged 31 commits intogrpc:new_invoke_apifrom
ctiller:api
Jan 15, 2015
Merged

New C layer invoke API#34
yang-g merged 31 commits intogrpc:new_invoke_apifrom
ctiller:api

Conversation

@ctiller
Copy link
Copy Markdown
Member

@ctiller ctiller commented Jan 15, 2015

We no longer generate an event after invoke, instead grpc_call_invoke is instantaneous and reads and writes can be queued immediately.

I'd started some prototyping work on this change before the move to
GitHub; this change restores things.
By the time we call accept, we have proof that we've received the start
of a call, so we should set this bit to one.
Otherwise we can cause segfaults down in the client_channel.
So that later cancellations do not clobber status.
This prevents mismatches from breaking tests.
If not running in forever mode, and a test fails, fail run_tests.py
also.

If running in forever mode and make fails, wait for the next run.
Also allow maxjobs to be tweaked based upon which configs are being run,
to prevent memory starvation.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call->start_ok = 0; ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

yang-g added a commit that referenced this pull request Jan 15, 2015
New C layer invoke API
@yang-g yang-g merged commit ea36ba3 into grpc:new_invoke_api Jan 15, 2015
@yang-g yang-g deleted the api branch January 15, 2015 07:39
jtattermusch pushed a commit that referenced this pull request Jun 18, 2016
apolcyn referenced this pull request in apolcyn/grpc Jul 25, 2016
De-tinified protobuf font for main page
@lock lock bot locked as resolved and limited conversation to collaborators Feb 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants