Remove a major source of contention in thread_pool#325
Merged
vjpai merged 2 commits intogrpc:masterfrom Feb 2, 2015
ctiller:threads
Merged
Remove a major source of contention in thread_pool#325vjpai merged 2 commits intogrpc:masterfrom ctiller:threads
vjpai merged 2 commits intogrpc:masterfrom
ctiller:threads
Conversation
- notify_one when new work is available to avoid thundering herd problems - checking conditions before entering cv_.wait() prevents a case that these are not validated
And make it easy not to make the same mistake
vjpai
added a commit
that referenced
this pull request
Feb 2, 2015
Remove a major source of contention in thread_pool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problems
these are not validated