xDS fault injection e2e test: fix flakes caused by processing queued calls in parallel#32429
Merged
markdroth merged 1 commit intogrpc:masterfrom Feb 17, 2023
Merged
Conversation
…calls in parallel
markdroth
added
the
release notes: no
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/none
labels
copybara-service
bot
added
the
imported
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
…calls in parallel (grpc#32429) The `XdsFaultInjectionMaxFault` test has seen a few flakes since grpc#32326 was merged. I believe the flakiness is caused by the fact that when a large number of RPCs are queued up before the resolver result comes in, those RPCs are now re-processed in parallel instead of sequentially, which can cause us to delay more RPCs than we should due to the `max_faults` setting. To fix this, we change the test to ensure that the channel is connected (i.e., the resolver result has already been returned) before we start sending a large number of concurrent RPCs. Although this is the only test that I've seen flakes in, I've made this same change consistently to all fault injection tests that are creating a large number of concurrent RPCs, since the same flake could affect any of them.
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
…calls in parallel (#32429) The `XdsFaultInjectionMaxFault` test has seen a few flakes since #32326 was merged. I believe the flakiness is caused by the fact that when a large number of RPCs are queued up before the resolver result comes in, those RPCs are now re-processed in parallel instead of sequentially, which can cause us to delay more RPCs than we should due to the `max_faults` setting. To fix this, we change the test to ensure that the channel is connected (i.e., the resolver result has already been returned) before we start sending a large number of concurrent RPCs. Although this is the only test that I've seen flakes in, I've made this same change consistently to all fault injection tests that are creating a large number of concurrent RPCs, since the same flake could affect any of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
XdsFaultInjectionMaxFaulttest has seen a few flakes since #32326 was merged. I believe the flakiness is caused by the fact that when a large number of RPCs are queued up before the resolver result comes in, those RPCs are now re-processed in parallel instead of sequentially, which can cause us to delay more RPCs than we should due to themax_faultssetting. To fix this, we change the test to ensure that the channel is connected (i.e., the resolver result has already been returned) before we start sending a large number of concurrent RPCs.Although this is the only test that I've seen flakes in, I've made this same change consistently to all fault injection tests that are creating a large number of concurrent RPCs, since the same flake could affect any of them.