GCP Observability : Framework for detecting the environment#32294
Merged
yashykt merged 28 commits intogrpc:masterfrom Feb 17, 2023
Merged
GCP Observability : Framework for detecting the environment#32294yashykt merged 28 commits intogrpc:masterfrom
yashykt merged 28 commits intogrpc:masterfrom
Conversation
veblush
approved these changes
Feb 3, 2023
2ef708d to
fc9b580
Compare
ctiller
reviewed
Feb 5, 2023
drfloob
reviewed
Feb 10, 2023
drfloob
reviewed
Feb 14, 2023
apolcyn
requested changes
Feb 14, 2023
apolcyn
reviewed
Feb 15, 2023
markdroth
reviewed
Feb 16, 2023
Member
markdroth
left a comment
There was a problem hiding this comment.
I like this structure much better!
markdroth
approved these changes
Feb 16, 2023
apolcyn
added a commit
that referenced
this pull request
Feb 28, 2023
In #32294 , we accidentally stopped plumbing `grpc.testing.google_c2p_resolver_metadata_server_override` to the metadata server http queries. So, we stopped actually using the fake metadata servers injected in https://github.com/grpc/grpc/blob/b3d68001f7420ccb47615ed88ac79b4c0456f897/test/core/client_channel/resolvers/google_c2p_resolver_test.cc#L48. The brings that back.
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
This code is not plumbed through yet, but it provides the core infrastructure needed to detect the proper GCP environment resources needed to set up the labels/attributes/resources for stats, tracing and logging. Details on how the various environment resources are setup has been derived by looking at java's cloud logging library and OpenTelemetry's future plans. (Could be better explained in an offline review since some links are internal). Requesting @veblush for a full review and @markdroth for a structural review. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
In grpc#32294 , we accidentally stopped plumbing `grpc.testing.google_c2p_resolver_metadata_server_override` to the metadata server http queries. So, we stopped actually using the fake metadata servers injected in https://github.com/grpc/grpc/blob/b3d68001f7420ccb47615ed88ac79b4c0456f897/test/core/client_channel/resolvers/google_c2p_resolver_test.cc#L48. The brings that back.
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
This code is not plumbed through yet, but it provides the core infrastructure needed to detect the proper GCP environment resources needed to set up the labels/attributes/resources for stats, tracing and logging. Details on how the various environment resources are setup has been derived by looking at java's cloud logging library and OpenTelemetry's future plans. (Could be better explained in an offline review since some links are internal). Requesting @veblush for a full review and @markdroth for a structural review. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
In #32294 , we accidentally stopped plumbing `grpc.testing.google_c2p_resolver_metadata_server_override` to the metadata server http queries. So, we stopped actually using the fake metadata servers injected in https://github.com/grpc/grpc/blob/b3d68001f7420ccb47615ed88ac79b4c0456f897/test/core/client_channel/resolvers/google_c2p_resolver_test.cc#L48. The brings that back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code is not plumbed through yet, but it provides the core infrastructure needed to detect the proper GCP environment resources needed to set up the labels/attributes/resources for stats, tracing and logging.
Details on how the various environment resources are setup has been derived by looking at java's cloud logging library and OpenTelemetry's future plans. (Could be better explained in an offline review since some links are internal).
Requesting @veblush for a full review and @markdroth for a structural review.