Skip to content

GCP Observability : Framework for detecting the environment#32294

Merged
yashykt merged 28 commits intogrpc:masterfrom
yashykt:ObservabilityEnvLabels
Feb 17, 2023
Merged

GCP Observability : Framework for detecting the environment#32294
yashykt merged 28 commits intogrpc:masterfrom
yashykt:ObservabilityEnvLabels

Conversation

@yashykt
Copy link
Copy Markdown
Member

@yashykt yashykt commented Feb 3, 2023

This code is not plumbed through yet, but it provides the core infrastructure needed to detect the proper GCP environment resources needed to set up the labels/attributes/resources for stats, tracing and logging.

Details on how the various environment resources are setup has been derived by looking at java's cloud logging library and OpenTelemetry's future plans. (Could be better explained in an offline review since some links are internal).

Requesting @veblush for a full review and @markdroth for a structural review.

@yashykt yashykt requested a review from apolcyn February 15, 2023 21:17
Copy link
Copy Markdown
Contributor

@apolcyn apolcyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this structure much better!

@yashykt yashykt enabled auto-merge (squash) February 16, 2023 22:52
@yashykt yashykt merged commit 04e3a8e into grpc:master Feb 17, 2023
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Feb 17, 2023
apolcyn added a commit that referenced this pull request Feb 28, 2023
In #32294 , we accidentally stopped
plumbing `grpc.testing.google_c2p_resolver_metadata_server_override` to
the metadata server http queries. So, we stopped actually using the fake
metadata servers injected in
https://github.com/grpc/grpc/blob/b3d68001f7420ccb47615ed88ac79b4c0456f897/test/core/client_channel/resolvers/google_c2p_resolver_test.cc#L48.

The brings that back.
XuanWang-Amos pushed a commit to XuanWang-Amos/grpc that referenced this pull request May 1, 2023
This code is not plumbed through yet, but it provides the core
infrastructure needed to detect the proper GCP environment resources
needed to set up the labels/attributes/resources for stats, tracing and
logging.

Details on how the various environment resources are setup has been
derived by looking at java's cloud logging library and OpenTelemetry's
future plans. (Could be better explained in an offline review since some
links are internal).

Requesting @veblush for a full review and @markdroth for a structural
review.

<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
XuanWang-Amos pushed a commit to XuanWang-Amos/grpc that referenced this pull request May 1, 2023
In grpc#32294 , we accidentally stopped
plumbing `grpc.testing.google_c2p_resolver_metadata_server_override` to
the metadata server http queries. So, we stopped actually using the fake
metadata servers injected in
https://github.com/grpc/grpc/blob/b3d68001f7420ccb47615ed88ac79b4c0456f897/test/core/client_channel/resolvers/google_c2p_resolver_test.cc#L48.

The brings that back.
wanlin31 pushed a commit that referenced this pull request May 18, 2023
This code is not plumbed through yet, but it provides the core
infrastructure needed to detect the proper GCP environment resources
needed to set up the labels/attributes/resources for stats, tracing and
logging.

Details on how the various environment resources are setup has been
derived by looking at java's cloud logging library and OpenTelemetry's
future plans. (Could be better explained in an offline review since some
links are internal).

Requesting @veblush for a full review and @markdroth for a structural
review.

<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
wanlin31 pushed a commit that referenced this pull request May 18, 2023
In #32294 , we accidentally stopped
plumbing `grpc.testing.google_c2p_resolver_metadata_server_override` to
the metadata server http queries. So, we stopped actually using the fake
metadata servers injected in
https://github.com/grpc/grpc/blob/b3d68001f7420ccb47615ed88ac79b4c0456f897/test/core/client_channel/resolvers/google_c2p_resolver_test.cc#L48.

The brings that back.
@yashykt yashykt deleted the ObservabilityEnvLabels branch May 18, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bloat/low imported Specifies if the PR has been imported to the internal repository lang/c++ per-call-memory/neutral per-channel-memory/neutral release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants