-
Notifications
You must be signed in to change notification settings - Fork 11k
[Ruby] Stop stripping exported symbols #31151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This commit stops stripping exported symbols in the compiled binary. This will ensure that functions like `Init_grpc` and `ruby_abi_version` are not removed from the generated binary. Fixes grpc#30976.
|
Thanks - this lets grpc compile under Ruby 2.7.4 [tested] |
|
@apolcyn can we please make this a priority to merge and release? It's blocking Mac M1 users from installing latest GRPC on Ruby with this error: |
|
@johnnyshields A work around is that you may run
before This should allow the gem to build on Apple Silicon/XCode 14 |
|
@apolcyn any update on this? |
|
Thanks for the PR @johnnyshields and sorry for the review delay. Thinking about this more, I'm actually favoring a slightly different approach - I opened #31970 - PLMK if you have any thoughts about that. |
|
This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 30 days. It will be closed automatically if no further update occurs in 7 day. Thank you for your contributions! |
|
@peterzhu2118 @apolcyn I assume this can be closed? |
This commit stops stripping exported symbols in the compiled binary. This will ensure that functions like
Init_grpcandruby_abi_versionare not removed from the generated binary.Fixes #30976.