Remove g_glip and class GrpcLibraryInterface#30414
Merged
ralphchung merged 35 commits intogrpc:masterfrom Nov 14, 2022
Merged
Conversation
ralphchung
added
kokoro:force-run
release notes: no
ralphchung
force-pushed
the
eliminate-impl-codegen-directories
branch
from
ca717df to
afb833f
Compare
ralphchung
force-pushed
the
eliminate-impl-codegen-directories
branch
from
afb833f to
e63696c
Compare
Vignesh2208
requested changes
Jul 27, 2022
Contributor
Vignesh2208
left a comment
Vignesh2208
left a comment
There was a problem hiding this comment.
Looks mostly good to me.
include/grpcpp/grpc_library.h
Outdated
|
|
||
| private: | ||
| bool grpc_init_called_; | ||
| static internal::GrpcLibrary internal_grpc_library; |
Contributor
There was a problem hiding this comment.
Why is there a static grpc::internal::GrpcLibrary ? It seems like its methods only call grpc_init() and grpc_shutdown(). Why not call them directly in grpc::GrpcLibrary constructor and destructor respectively ?
Vignesh2208
reviewed
Jul 27, 2022
include/grpcpp/grpc_library.h
Outdated
| /* | ||
| * | ||
| * Copyright 2018 gRPC authors. | ||
| * Copyright 2022 gRPC authors. |
Contributor
There was a problem hiding this comment.
Please switch to newer style C++ header/copyright comments in this the file (e.g, src/core/lib/event_engine/iomgr_engine/ev_epoll1_linux.cc)
Member
|
Just noting here: this will need an internal cherry-pick, as there are internal usages of this header. |
ralphchung
force-pushed
the
eliminate-impl-codegen-directories
branch
from
cfec6a3 to
0c947b1
Compare
ralphchung
force-pushed
the
eliminate-impl-codegen-directories
branch
from
0c947b1 to
28c37e2
Compare
…degen-directories
ralphchung
force-pushed
the
eliminate-impl-codegen-directories
branch
from
ed520c6 to
d52be99
Compare
…degen-directories
ralphchung
force-pushed
the
eliminate-impl-codegen-directories
branch
from
d52be99 to
989d5fd
Compare
ralphchung
force-pushed
the
eliminate-impl-codegen-directories
branch
from
989d5fd to
2f5c77e
Compare
…degen-directories
This reverts commit 2f5c77e.
…degen-directories
…e-impl-codegen-directories
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR requires cherry picking before merging.
This PR aims to remove the pointer
g_glipandclass GrpcLibraryInterface.Details:
grpc::GrpcLibraryCodegenis moved togrpc::GrpcLibraryto replace the need for pointerg_glip.grpc::GrpcLibraryInterfaceis removed.