Skip to content

[Draft] Implement 3rd-party (envoy) proto generation mechanism#29214

Closed
lidizheng wants to merge 5 commits intogrpc:masterfrom
lidizheng:xp
Closed

[Draft] Implement 3rd-party (envoy) proto generation mechanism#29214
lidizheng wants to merge 5 commits intogrpc:masterfrom
lidizheng:xp

Conversation

@lidizheng
Copy link
Copy Markdown
Contributor

  • Works for both CMake and Bazel
  • Instrument xds_end2end_test with protos from envoy-api
  • Fixed the Bazel repo naming with re2
  • Refactor the build metadata compute algorithm
    • Now, in one pass, it will generate all the build metadata needed within
      this script, including the transitive deps, the sources/headers expanded
      without intermediate dependencies.
  • Temporarily remove the removal of third_party dependencies
  • Spin-off changes to sub PRs
  • Add a fetching mechanism for external proto libs
  • Accommodate Windows' CMake behavior difference
  • Allow CMakefile to fetch external library
    • The URL is parsed from grpc_deps
    • Allow multiple download URLs for extra stability

@lidizheng lidizheng added the release notes: no Indicates if PR should not be in release notes label Mar 24, 2022
* Works for both CMake and Bazel
* Instrument xds_end2end_test with protos from envoy-api
* Fixed the Bazel repo naming with re2
* Refactor the build metadata compute algorithm
    * Now, in one pass, it will generate all the build metadata needed within
    this script, including the transitive deps, the sources/headers expanded
    without intermediate dependencies.
* Temporarily remove the removal of third_party dependencies
* Spin-off changes to sub PRs
* Add a fetching mechanism for external proto libs
* Accommodate Windows' CMake behavior difference
* Allow CMakefile to fetch external library
    * The URL is parsed from grpc_deps
    * Allow multiple download URLs for extra stability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants