Upgrade benchmark to 1.6.0 and remove previous hacks.#27778
Merged
veblush merged 7 commits intogrpc:masterfrom Oct 27, 2021
Merged
Upgrade benchmark to 1.6.0 and remove previous hacks.#27778veblush merged 7 commits intogrpc:masterfrom
veblush merged 7 commits intogrpc:masterfrom
Conversation
Details: - GRPC currently uses an old version of benchmark (from Sept 2020). It should probably upgrade because downstream, in google3, everyone is already using 1.6.0) - Removed the hack added in PR/27629 to allow benchmarks in GRPC to continue to work with both pre-1.6.0 and 1.6.0 benchmarks. (This was needed to allow importing benchmarks 1.6.0 into google3 without breaking GRPC)
oontvoo
requested review from
ctiller,
gnossen,
jtattermusch,
nicolasnoble and
veblush
as code owners
jtattermusch
added
kokoro:run
release notes: no
Contributor
|
@veblush please review. |
Contributor
|
@veblush please review. |
veblush
approved these changes
Oct 21, 2021
Contributor
veblush
left a comment
veblush
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the PR!
veblush
reviewed
Oct 21, 2021
Contributor
Contributor
Author
Thanks. For the third_party/benchmark, what I ran was: Please verify these were the correct steps. |
Contributor
|
It looks right. Let's see what Kokoro will say. |
Contributor
Author
|
Hi, friendly ping? |
Contributor
|
@oontvoo Would you run |
* Bump version to v1.41.0-pre1 (grpc#27371) * Bump version to v1.41.0-pre1 * Regenerate projects * [Backport grpc#27373] add testing_version flag (grpc#27385) * Bump version to v1.41.0-pre2 (grpc#27390) * Bump version to v1.41.0-pre2 * Regenerate projects * Core 19: bump core version from 18.0.0 to 19.0.0 (grpc#27394) * Bump core version to 19.0.0 * Regenerate projects * fix use-after-free metadata corruption in C# when receiving response headers for streaming response calls (grpc#27398) * Final release: bump up version to 1.41.0 (grpc#27476) * Bump version to 1.41.0 * Regenerate projects * xds_k8s_test: increase timeout to 3 hours due to recent timeout failure (grpc#27580) * Revert "xds_k8s_test: increase timeout to 3 hours due to recent timeout failure (grpc#27580)" (grpc#27590) This reverts commit da0c7d6. * Update root pem certs (backport of grpc#27539) (grpc#27619) * Update boringssl to the latest (grpc#27606) (grpc#27625) * Change boringssl branch name * update submodule boringssl-with-bazel with origin/main-with-bazel * update boringssl dependency to main-with-bazel commit SHA * regenerate files * Increment podspec version * generate boringssl prefix headers * Bumping up version to v1.41.1 (grpc#27699) * Bump version to v1.41.1 * Regenerate projects * [Backport][v1.41.x] xds-k8s tests: Use test driver from master branch (grpc#27695) Backports sourcing the test driver install script from master. This is a backport of grpc#27389, grpc#27462 and grpc#27658: * Add missing quatation marks. These were missed when creating the Python virtual env. * xds-k8s tests: Use test driver from master branch (grpc#27462) Instead of directly sourcing the test driver provisioning script from the same branch, the script is downloaded (with curl) and sourced from the master branch. This allows changes made to the test driver to be reflected in all future release branches. A separate PR will backport this change to existing release branches. All cluster definitions are also moved to the install script, allowing any cluster changes to be done in one place in the master branch. * xds_k8s tests: Fix xlang install script sourcing. (grpc#27658) This change sources the test driver install script correctly for the xlang tests. This fixes a mistake in grpc#27462 where this was missed. * Fix Python Interop (grpc#27620) (grpc#27703) * WIP. Attempt to fix interop * Yapf * Switch Python xDS Example Server to Listen on IPV4 Only (grpc#27679) * Switch to IPV4 * Update to all hosts * Fix rvm ruby install failure (grpc#27769) Co-authored-by: donnadionne <[email protected]> Co-authored-by: Lidi Zheng <[email protected]> Co-authored-by: Jan Tattermusch <[email protected]> Co-authored-by: sanjaypujare <[email protected]> Co-authored-by: Sergii Tkachenko <[email protected]> Co-authored-by: Esun Kim <[email protected]> Co-authored-by: Terry Wilson <[email protected]> Co-authored-by: Richard Belleville <[email protected]>
copybara-service
bot
added
the
imported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
(This was needed to allow importing benchmarks 1.6.0 into google3 without breaking GRPC)
Background:
This originated from PR/27505 - From various discussions internally, we've decided it was simpler to add the hack (PR/27629), do the import, then revert the hack and upgrade benchmark versions.
@markdroth @veblush @dominichamon