[Backport][v1.39.x] xds-k8s tests: Use test driver from master branch#27692
Merged
srini100 merged 2 commits intogrpc:v1.39.xfrom Oct 13, 2021
Merged
[Backport][v1.39.x] xds-k8s tests: Use test driver from master branch#27692srini100 merged 2 commits intogrpc:v1.39.xfrom
srini100 merged 2 commits intogrpc:v1.39.xfrom
Conversation
These were missed when creating the Python virtual env.
temawi
force-pushed
the
v1.39.x-xds-k8s-install-from-master
branch
from
9546c78 to
596c25b
Compare
Instead of directly sourcing the test driver provisioning script from the same branch, the script is downloaded (with curl) and sourced from the master branch. This allows changes made to the test driver to be reflected in all future release branches. A separate PR will backport this change to existing release branches. All cluster definitions are also moved to the install script, allowing any cluster changes to be done in one place in the master branch.
sergiitk
added
area/test
release notes: no
sergiitk
reviewed
Oct 12, 2021
| # Constants | ||
| readonly GITHUB_REPOSITORY_NAME="grpc" | ||
| # GKE Cluster | ||
| readonly GKE_CLUSTER_NAME="interop-test-psm-sec-v2-us-central1-a" |
Member
There was a problem hiding this comment.
TIL This's still using PSM Sec cluster. That's why we need these backports, and activate_gke_cluster feature. Thanks, Terry.
cc @lidizheng
Contributor
There was a problem hiding this comment.
Thanks for updating the GKE cluster!
sergiitk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports sourcing the test driver install script from master.
This is a backport of #27389 and #27462
xds_k8s test run: https://fusion2.corp.google.com/invocations/36f531c8-7928-4787-97bc-6ab66bb08a7b/targets
xds_k8s_python test run: https://fusion2.corp.google.com/invocations/8bb10a89-fb58-485c-b259-d7eff9a3b6ab/targets
@sergiitk