Skip to content

[Backport][v1.38.x] xds-k8s tests: Use test driver from master branch#27691

Merged
srini100 merged 2 commits intogrpc:v1.38.xfrom
temawi:v1.38.x-xds-k8s-install-from-master
Oct 13, 2021
Merged

[Backport][v1.38.x] xds-k8s tests: Use test driver from master branch#27691
srini100 merged 2 commits intogrpc:v1.38.xfrom
temawi:v1.38.x-xds-k8s-install-from-master

Conversation

@temawi
Copy link
Copy Markdown
Contributor

@temawi temawi commented Oct 12, 2021

@sergiitk sergiitk self-requested a review October 12, 2021 16:52
@sergiitk sergiitk added area/test release notes: no Indicates if PR should not be in release notes labels Oct 12, 2021
Copy link
Copy Markdown
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: rebase against v1.38.x to include patch for the Sanity Check

@sergiitk sergiitk changed the title V1.38.x xds k8s install from master [Backport][v1.38.x] xds-k8s tests: Use test driver from master branch Oct 12, 2021
These were missed when  creating the Python virtual env.
Instead of directly sourcing the test driver provisioning script from the same branch, the script is downloaded (with curl) and sourced from the master branch.

This allows changes made to the test driver to be reflected in all future release branches. A separate PR will backport this change to existing release branches.

All cluster definitions are also moved to the install script, allowing any cluster changes to be done in one place in the master branch.
@temawi temawi force-pushed the v1.38.x-xds-k8s-install-from-master branch from 7ae2fc8 to a77b74d Compare October 13, 2021 17:03
@srini100 srini100 merged commit f2bbfb2 into grpc:v1.38.x Oct 13, 2021
@temawi temawi deleted the v1.38.x-xds-k8s-install-from-master branch October 13, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants