[Backport][v1.37.x] xds-k8s tests: Use test driver from master branch#27681
Merged
srini100 merged 2 commits intogrpc:v1.37.xfrom Oct 13, 2021
Merged
[Backport][v1.37.x] xds-k8s tests: Use test driver from master branch#27681srini100 merged 2 commits intogrpc:v1.37.xfrom
srini100 merged 2 commits intogrpc:v1.37.xfrom
Conversation
sergiitk
reviewed
Oct 11, 2021
Member
sergiitk
left a comment
sergiitk
left a comment
There was a problem hiding this comment.
As I understand, we should delete tools/internal_ci/linux/grpc_xds_k8s_install_test_driver.sh now. Since it's not a backport, I think we should just make add a commit. This commit can be cherry-picked to other branches in further PRs.
sergiitk
approved these changes
Oct 11, 2021
Member
sergiitk
left a comment
sergiitk
left a comment
There was a problem hiding this comment.
Discussed IRL. Deleting the shared file makes little sense. When new versions are cut, this file will be present in them anyway.
sergiitk
added
release notes: no
sergiitk
changed the title
temawi
requested review from
apolcyn,
jtattermusch and
nicolasnoble
as code owners
These were missed when creating the Python virtual env.
Instead of directly sourcing the test driver provisioning script from the same branch, the script is downloaded (with curl) and sourced from the master branch. This allows changes made to the test driver to be reflected in all future release branches. A separate PR will backport this change to existing release branches. All cluster definitions are also moved to the install script, allowing any cluster changes to be done in one place in the master branch.
temawi
force-pushed
the
v1.37.x-xds-k8s-install-from-master
branch
from
f9c68d1 to
0802585
Compare
sergiitk
approved these changes
Oct 13, 2021
Member
sergiitk
left a comment
sergiitk
left a comment
There was a problem hiding this comment.
Sanity Checks passed - this can be merged now. Thank you so much for getting this right!
Contributor
Author
|
@sergiitk I don't have permission to merge, can you kick that off please? |
Member
|
Neither do I - all but a few recent branches are protected. I'll forward this to @srini100. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports sourcing the test driver install script from master.
This is a backport of #27389 and #27462
@sergiitk