Skip to content

Fix rvm ruby install failure#27538

Merged
drfloob merged 11 commits intogrpc:masterfrom
drfloob:rvm-install-fix
Oct 5, 2021
Merged

Fix rvm ruby install failure#27538
drfloob merged 11 commits intogrpc:masterfrom
drfloob:rvm-install-fix

Conversation

@drfloob
Copy link
Copy Markdown
Member

@drfloob drfloob commented Sep 30, 2021 •
edited by gnossen
Loading

See https://source.cloud.google.com/results/invocations/9a2a3ca2-72c9-43ef-af8c-fb1c8e7b488d/targets/grpc%2Fcore%2Fpull_request%2Fmacos%2Fgrpc_basictests_ruby/log

++ rvm get stable
Downloading https://get.rvm.io
Could not download rvm-installer, please report to https://github.com/rvm/rvm/issues

Fixes #27585

cc @apolcyn

@drfloob drfloob added area/test release notes: no Indicates if PR should not be in release notes labels Sep 30, 2021
@drfloob
Copy link
Copy Markdown
Member Author

drfloob commented Sep 30, 2021

This may be a transient issue, the debug logs were not terribly helpful.

@drfloob
Copy link
Copy Markdown
Member Author

drfloob commented Oct 4, 2021

This is an RVM issue, tracked here: rvm/rvm#5133. I will look into a workaround.

@drfloob drfloob mentioned this pull request Oct 4, 2021
Merged
@drfloob drfloob changed the title debug rvm install failure Fix rvm ruby install failure Oct 4, 2021
@drfloob drfloob requested a review from apolcyn October 4, 2021 21:36
@drfloob drfloob marked this pull request as ready for review October 4, 2021 21:47
@drfloob
Copy link
Copy Markdown
Member Author

drfloob commented Oct 4, 2021

Workaround: since rvm uses curl under the hood, for now we will tell curl to rely on the root certificates that are bundled with gRPC. They were last updated a few days ago to remove the offending DST Root CA X3 root cert.

apolcyn
apolcyn approved these changes Oct 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@apolcyn apolcyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@drfloob drfloob enabled auto-merge (squash) October 4, 2021 22:46
@drfloob drfloob mentioned this pull request Oct 4, 2021
Closed
@drfloob
Copy link
Copy Markdown
Member Author

drfloob commented Oct 4, 2021

Fixes #27585

@drfloob drfloob merged commit 99ee6f4 into grpc:master Oct 5, 2021
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Oct 5, 2021
@drfloob drfloob mentioned this pull request Oct 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apolcyn apolcyn apolcyn approved these changes

Assignees

No one assigned

Labels

area/test imported Specifies if the PR has been imported to the internal repository release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

get.rvm.io Failing Consistently

2 participants

@drfloob @apolcyn