Skip to content

upgrade benchmark version to latest#27505

Closed
dmah42 wants to merge 1 commit intogrpc:masterfrom
dmah42:upgrade_bm
Closed

upgrade benchmark version to latest#27505
dmah42 wants to merge 1 commit intogrpc:masterfrom
dmah42:upgrade_bm

Conversation

@dmah42
Copy link
Copy Markdown

@dmah42 dmah42 commented Sep 28, 2021

The newer versions of benchmark include some improvements, but also a breaking API change was just made and it would be good to get past that.

@donnadionne

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Sep 28, 2021

CLA Signed

The committers are authorized under a signed CLA.

@jtattermusch
Copy link
Copy Markdown
Contributor

Why is this important? The PR doesn't have a description.

@markdroth
Copy link
Copy Markdown
Member

It looks like there are some other callers of state.thread_index that need to be updated in test/cpp/microbenchmarks/bm_threadpool.cc. See the test failures for details.

@markdroth markdroth self-assigned this Oct 4, 2021
@veblush
Copy link
Copy Markdown
Contributor

veblush commented Oct 5, 2021

@dominichamon Thanks for the PR and you may want to follow the procedure to update this dependency.

@veblush
Copy link
Copy Markdown
Contributor

veblush commented Oct 27, 2021

Superseded by #27778

@veblush veblush closed this Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants