Skip to content

[objc] Fix firestone linux cocoapod grpc install issue#27300

Merged
dennycd merged 1 commit intogrpc:masterfrom
dennycd:cocoapod_linux_fix
Sep 10, 2021
Merged

[objc] Fix firestone linux cocoapod grpc install issue#27300
dennycd merged 1 commit intogrpc:masterfrom
dennycd:cocoapod_linux_fix

Conversation

@dennycd
Copy link
Copy Markdown
Contributor

@dennycd dennycd commented Sep 9, 2021 •
edited
Loading

Fixing gRPC cocoapod installation issue on GNU/Linux which are previously mentioned in the following

#26630
firebase/quickstart-ios#1099
firebase/firebase-ios-sdk#736 (comment)

Currently this is preventing firebase/firestone cocoapod to install on linux for internal users but may potentially affect anyone who want to use gRPC cocoapod on GNU/Linux. Manually tested the installation on linux box of the following spec

Linux # 1 SMP Debian 5.10.40-1rodete2 (2021-06-22) x86_64 GNU/Linux

Clients need to update to latest next gRPC release v1.41.x in order to pick up this patch. (Firebase/Firestore currently on v1.28.0)

@dennycd dennycd added lang/ObjC platform/iOS release notes: no Indicates if PR should not be in release notes labels Sep 9, 2021
@dennycd dennycd force-pushed the cocoapod_linux_fix branch 3 times, most recently from f72cc44 to 9e1e779 Compare September 10, 2021 06:21
sampajano
sampajano approved these changes Sep 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@sampajano sampajano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! 😃 (Btw I don't know much about those cmd flags so just trusting your testing 😄)

@dennycd dennycd mentioned this pull request Sep 10, 2021
Closed
@morganchen12 morganchen12 mentioned this pull request Sep 10, 2021
Closed
@dennycd dennycd merged commit 610db37 into grpc:master Sep 10, 2021
jtattermusch
jtattermusch reviewed Sep 17, 2021
View reviewed changes
src/objective-c/BoringSSL-GRPC.podspec
base64 -D <<EOF | gunzip > src/include/openssl/boringssl_prefix_symbols.h
case "$(uname)" in
Darwin) opts="" ;;
*) opts="--ignore-garbage" ;;
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch Sep 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think overall this PR looks good, but what was the "garbage" that needed to be ignored when on linux? Was it the newlines/spaces?

Copy link
Copy Markdown
Contributor Author

@dennycd dennycd Sep 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jan. Yes exactly, for linux variation (https://linux.die.net/man/1/base64) by default it does not handle non-alphabet bytes in the encode string, in this case the newline inside the podspec. On Darwin base64 this is automatically handled by default (https://www.unix.com/man-page/osx/1/base64/)

lidizheng pushed a commit to lidizheng/grpc that referenced this pull request Sep 23, 2021
@dennycd @lidizheng
[objc] Fix firestone linux cocoapod grpc install issue (grpc#27300)
3f15826 
all checks green, merge and close
@morganchen12 morganchen12 mentioned this pull request Mar 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampajano sampajano sampajano approved these changes

@stanley-cheung stanley-cheung Awaiting requested review from stanley-cheung

+1 more reviewer

@jtattermusch jtattermusch jtattermusch left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lang/ObjC platform/iOS release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dennycd @sampajano @jtattermusch