Skip to content

Use manylinux_2_17 instead of manylinux_2_24 tag for manylinux2014 aarch64 wheels#27280

Merged
jtattermusch merged 3 commits intogrpc:masterfrom
jtattermusch:py-64
Sep 9, 2021
Merged

Use manylinux_2_17 instead of manylinux_2_24 tag for manylinux2014 aarch64 wheels#27280
jtattermusch merged 3 commits intogrpc:masterfrom
jtattermusch:py-64

Conversation

@jtattermusch
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch commented Sep 8, 2021 •
edited
Loading

Follow-up on #26074 (comment)

Based on @lidizheng 's #27239

Since for crosscompiled aarch64 wheels we currently don't run "auditwheel repair", the resulting wheels need to be manually checked for manylinux_2_17 compliance.

@jtattermusch jtattermusch added lang/Python release notes: yes Indicates if PR needs to be in release notes labels Sep 8, 2021
@jtattermusch jtattermusch mentioned this pull request Sep 8, 2021
Closed
@jtattermusch
Copy link
Copy Markdown
Contributor Author

jtattermusch commented Sep 9, 2021 •
edited
Loading

Manual auditwheel show run on aarch64 machine:

python3.8 -m auditwheel show grpcio-1.41.0.dev0-cp38-cp38-manylinux_2_17_aarch64.whl 

grpcio-1.41.0.dev0-cp38-cp38-manylinux_2_17_aarch64.whl is consistent
with the following platform tag: "manylinux_2_17_aarch64".

The wheel references external versioned symbols in these
system-provided shared libraries: libpthread.so.0 with versions
{'GLIBC_2.17'}, libm.so.6 with versions {'GLIBC_2.17'}, libc.so.6 with
versions {'GLIBC_2.17'}, libstdc++.so.6 with versions
{'GLIBCXX_3.4.17', 'GLIBCXX_3.4.18', 'GLIBCXX_3.4.15',
'GLIBCXX_3.4.9', 'CXXABI_1.3', 'GLIBCXX_3.4', 'GLIBCXX_3.4.11',
'CXXABI_1.3.5', 'GLIBCXX_3.4.14'}

The following external shared libraries are required by the wheel:
{
    "libc.so.6": "/lib/aarch64-linux-gnu/libc-2.27.so",
    "libgcc_s.so.1": "/lib/aarch64-linux-gnu/libgcc_s.so.1",
    "libm.so.6": "/lib/aarch64-linux-gnu/libm-2.27.so",
    "libpthread.so.0": "/lib/aarch64-linux-gnu/libpthread-2.27.so",
    "librt.so.1": "/lib/aarch64-linux-gnu/librt-2.27.so",
    "libstdc++.so.6": "/usr/lib/aarch64-linux-gnu/libstdc++.so.6.0.25"
}

python3.8 -m auditwheel show grpcio_tools-1.41.0.dev0-cp38-cp38-manylinux_2_17_aarch64.whl 

grpcio_tools-1.41.0.dev0-cp38-cp38-manylinux_2_17_aarch64.whl is
consistent with the following platform tag: "manylinux_2_17_aarch64".

The wheel references external versioned symbols in these
system-provided shared libraries: libgcc_s.so.1 with versions
{'GCC_3.0', 'GCC_4.2.0'}, libpthread.so.0 with versions
{'GLIBC_2.17'}, libc.so.6 with versions {'GLIBC_2.17'}, libstdc++.so.6
with versions {'CXXABI_1.3', 'CXXABI_1.3.5', 'GLIBCXX_3.4.14',
'GLIBCXX_3.4.9', 'GLIBCXX_3.4.18', 'GLIBCXX_3.4', 'GLIBCXX_3.4.11'}

The following external shared libraries are required by the wheel:
{
    "libc.so.6": "/lib/aarch64-linux-gnu/libc-2.27.so",
    "libgcc_s.so.1": "/lib/aarch64-linux-gnu/libgcc_s.so.1",
    "libm.so.6": "/lib/aarch64-linux-gnu/libm-2.27.so",
    "libpthread.so.0": "/lib/aarch64-linux-gnu/libpthread-2.27.so",
    "libstdc++.so.6": "/usr/lib/aarch64-linux-gnu/libstdc++.so.6.0.25"
}

@jtattermusch jtattermusch merged commit 82d8bb0 into grpc:master Sep 9, 2021
ashithasantosh pushed a commit to ashithasantosh/grpc that referenced this pull request Sep 10, 2021
@jtattermusch @lidizheng @ashithasantosh
Use manylinux_2_17 instead of manylinux_2_24 tag for manylinux2014 aa…
b37d740 
…rch64 wheels (grpc#27280)

* Let's see if the aarch64 manylinux bug is fixed or not

* rename aarch64 image back to manylinux2014 for consistency

* fix C# aarch64 artifact build

Co-authored-by: Lidi Zheng <[email protected]>
lidizheng added a commit to lidizheng/grpc that referenced this pull request Sep 23, 2021
@jtattermusch @lidizheng
Use manylinux_2_17 instead of manylinux_2_24 tag for manylinux2014 aa…
60c3585 
…rch64 wheels (grpc#27280)

* Let's see if the aarch64 manylinux bug is fixed or not

* rename aarch64 image back to manylinux2014 for consistency

* fix C# aarch64 artifact build

Co-authored-by: Lidi Zheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnossen gnossen gnossen approved these changes

@apolcyn apolcyn Awaiting requested review from apolcyn

@nicolasnoble nicolasnoble Awaiting requested review from nicolasnoble

@lidizheng lidizheng Awaiting requested review from lidizheng

Assignees

@gnossen gnossen

Labels

lang/Python release notes: yes Indicates if PR needs to be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtattermusch @gnossen @lidizheng