Include "linux_extra" python artifacts in regular linux build#27279
Merged
jtattermusch merged 1 commit intogrpc:masterfrom Sep 9, 2021
Merged
Include "linux_extra" python artifacts in regular linux build#27279jtattermusch merged 1 commit intogrpc:masterfrom
jtattermusch merged 1 commit intogrpc:masterfrom
Conversation
jtattermusch
added
release notes: no
gnossen
approved these changes
Sep 8, 2021
Contributor
Author
|
linux build_artifact duration is now ~2h 18min (https://source.cloud.google.com/results/invocations/7df0dff0-289a-4a9f-8222-3532b97d8035/targets), on master the duration is currently between 105 and 126min (https://screenshot.googleplex.com/AQjfMdCvA7gTmPV) The job timeout is currently 180min: So this still feels like safe to merge. The python windows build failure (https://source.cloud.google.com/results/invocations/20ce277a-57bb-4f92-b954-78a8be28b953) is due to prepare build step failing, which is unrelated to this PR. |
ashithasantosh
pushed a commit
to ashithasantosh/grpc
that referenced
this pull request
Sep 10, 2021
lidizheng
pushed a commit
to lidizheng/grpc
that referenced
this pull request
Sep 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "linux_extra" artifacts used to be build in a fully emulated environment (which made for a terribly slow build), but now they are being crosscompiled, so their build time is comparable to other python wheels.
If we add linux_extra artifacts back to the "linux" artifacts, it will simplify the release process (avoiding the need to run a separate "linux_extra" kokoro job).
(We still need to check if adding more python artifacts will fit into the build_artifact job timeout, since we're already building a large number of linux wheels there).