Use manylinux_2_17 instead of manylinux_2_24 tag for manylinux2014 aarch64 wheels#27239
Closed
lidizheng wants to merge 1 commit intogrpc:masterfrom
Closed
Use manylinux_2_17 instead of manylinux_2_24 tag for manylinux2014 aarch64 wheels#27239lidizheng wants to merge 1 commit intogrpc:masterfrom
lidizheng wants to merge 1 commit intogrpc:masterfrom
Conversation
lidizheng
added
the
release notes: yes
jtattermusch
reviewed
Sep 3, 2021
| # instead of the incorrect manylinux2014 (see the note above). | ||
| ENV AUDITWHEEL_PLAT manylinux_2_24_$AUDITWHEEL_ARCH | ||
| # manylinux_2_17 is the preferred alias of manylinux2014 | ||
| ENV AUDITWHEEL_PLAT manylinux_2_17_$AUDITWHEEL_ARCH |
Contributor
There was a problem hiding this comment.
if this works, don't forget to rename the dockerfile to back to manylinux2014 (or to manylinux_2_17, but note that we are using manylinux2014 in the name of other docker images, so that might be a better choice)
Contributor
There was a problem hiding this comment.
we also need to check the resulting wheel with auditwheel on aarch64 to make sure it's really manylinux_2_17 compliant (it is, according to my earlier experiment, but it's better to doublecheck).
Contributor
|
superseded by #27280 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of Jan's comment in #26074.