Migrate binder transport end-to-end tests to use the existing testing service#27179
Merged
TaWeiTu merged 2 commits intogrpc:masterfrom Sep 17, 2021
Merged
Conversation
TaWeiTu
added
the
release notes: no
TaWeiTu
force-pushed
the
binder-transport-tests-use-testing-proto
branch
from
874b91a to
b264444
Compare
Contributor
Author
|
The change in |
Member
|
This is a bunch of different things piled into one PR and it's very difficult to review. Can you please separate things so that it's possible to review one facet of this at a time? |
TaWeiTu
force-pushed
the
binder-transport-tests-use-testing-proto
branch
from
b264444 to
35d2360
Compare
Contributor
Author
Sure, I've split the related changes into the following PRs:
Sorry for the inconvenience. |
TaWeiTu
force-pushed
the
binder-transport-tests-use-testing-proto
branch
from
35d2360 to
dd3adc0
Compare
TaWeiTu
force-pushed
the
binder-transport-tests-use-testing-proto
branch
from
dd3adc0 to
0aedce0
Compare
TaWeiTu
force-pushed
the
binder-transport-tests-use-testing-proto
branch
from
0aedce0 to
c84ec8c
Compare
TaWeiTu
force-pushed
the
binder-transport-tests-use-testing-proto
branch
2 times, most recently
from
4f154f0 to
4812821
Compare
TaWeiTu
force-pushed
the
binder-transport-tests-use-testing-proto
branch
4 times, most recently
from
26c0cda to
39b484e
Compare
sifmelcara
approved these changes
Sep 14, 2021
TaWeiTu
force-pushed
the
binder-transport-tests-use-testing-proto
branch
from
39b484e to
d57a3b1
Compare
copybara-service
bot
added
the
imported
lidizheng
pushed a commit
to lidizheng/grpc
that referenced
this pull request
Sep 23, 2021
… service (grpc#27179) * Use TestServiceImpl in binder end-to-end tests * Fix TSAN warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the existing
TestServiceImplfor binder transport end-to-end tests. This also allows us to test more functionalities than before.Depends on #27184.