Skip to content

Client fuzzer for binder transport#27052

Merged
TaWeiTu merged 3 commits intogrpc:masterfrom
TaWeiTu:client-fuzzer
Sep 15, 2021
Merged

Client fuzzer for binder transport#27052
TaWeiTu merged 3 commits intogrpc:masterfrom
TaWeiTu:client-fuzzer

Conversation

@TaWeiTu
Copy link
Copy Markdown
Contributor

@TaWeiTu TaWeiTu commented Aug 18, 2021

Add a client fuzzer for binder transport.

The fuzzer is very similar to test/core/end2end/fuzzers/client_fuzzer, with HTTP/2 transport being replaced by binder transport and HTTP/2 mock endpoints replaced by a almost-equivalent version of binder.

Depends on #27182.

@TaWeiTu TaWeiTu added the release notes: no Indicates if PR should not be in release notes label Aug 18, 2021
@TaWeiTu TaWeiTu force-pushed the client-fuzzer branch 4 times, most recently from 8b694e2 to 4ee14c1 Compare August 19, 2021 03:34
@TaWeiTu TaWeiTu marked this pull request as ready for review August 19, 2021 03:34
@TaWeiTu TaWeiTu requested review from ctiller and sifmelcara August 19, 2021 03:35
@TaWeiTu TaWeiTu force-pushed the client-fuzzer branch 2 times, most recently from f55f8d9 to f10eb79 Compare August 19, 2021 04:05
@TaWeiTu TaWeiTu force-pushed the client-fuzzer branch 3 times, most recently from 63d911b to a7cbc21 Compare August 20, 2021 04:19
@TaWeiTu TaWeiTu force-pushed the client-fuzzer branch 2 times, most recently from 5886e18 to af142c2 Compare August 25, 2021 08:46
@TaWeiTu TaWeiTu force-pushed the client-fuzzer branch 3 times, most recently from 04fa8c5 to 0bdd898 Compare August 30, 2021 09:16
@TaWeiTu TaWeiTu force-pushed the client-fuzzer branch 2 times, most recently from ff5e1f4 to f5c0fdc Compare August 30, 2021 17:39
@TaWeiTu TaWeiTu changed the title [binder] Add client fuzzer & Use combiner Client fuzzer for binder transport Aug 30, 2021
@TaWeiTu TaWeiTu marked this pull request as draft August 31, 2021 02:05
@ctiller ctiller removed their assignment Sep 1, 2021
@TaWeiTu TaWeiTu marked this pull request as ready for review September 8, 2021 14:01
@TaWeiTu TaWeiTu force-pushed the client-fuzzer branch 3 times, most recently from 3d39f3d to 39d6d8a Compare September 9, 2021 13:11
Copy link
Copy Markdown
Contributor

@sifmelcara sifmelcara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will finish my review when I got time. Any comments on corpus?

Copy link
Copy Markdown
Contributor

@sifmelcara sifmelcara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me generate a copybara import to see if it works

@TaWeiTu TaWeiTu force-pushed the client-fuzzer branch 2 times, most recently from d0fc880 to 746233a Compare September 11, 2021 07:08

licenses(["notice"])

load("//test/core/util:grpc_fuzzer.bzl", "grpc_fuzzer")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This load need to be moved to the top of the file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than this, copybara import looks ok

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This load need to be moved to the top of the file

Done.

Other than this, copybara import looks ok

Nice, thanks!

@TaWeiTu TaWeiTu force-pushed the client-fuzzer branch 2 times, most recently from f84209b to dc73e40 Compare September 14, 2021 05:39
@TaWeiTu TaWeiTu requested a review from sifmelcara September 14, 2021 06:20
@TaWeiTu TaWeiTu merged commit b455682 into grpc:master Sep 15, 2021
lidizheng pushed a commit to lidizheng/grpc that referenced this pull request Sep 23, 2021
* Add client fuzzer

* Limit readable parcel size to 1MB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang/core release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants