Skip to content

Revert "Adding grpc_init/grpc_shutdown to subchannel ctor/dtor to solve bugs related to async destruction of subchannels"#27004

Merged
ctiller merged 1 commit intomasterfrom
revert-26965-fix_async_subchannel_destroy_bug
Aug 13, 2021
Merged

Revert "Adding grpc_init/grpc_shutdown to subchannel ctor/dtor to solve bugs related to async destruction of subchannels"#27004
ctiller merged 1 commit intomasterfrom
revert-26965-fix_async_subchannel_destroy_bug

Conversation

@ctiller
Copy link
Copy Markdown
Member

@ctiller ctiller commented Aug 12, 2021

Reverts #26965

Breaks an internal test

…ve bugs related to async destruction of subchannels (#26965)"

This reverts commit a35a9e1.
@ctiller ctiller requested a review from markdroth as a code owner August 12, 2021 22:59
@ctiller ctiller added the release notes: no Indicates if PR should not be in release notes label Aug 12, 2021
@ctiller ctiller requested review from Vignesh2208 and yashykt August 12, 2021 23:04
@ctiller ctiller enabled auto-merge (squash) August 12, 2021 23:06
@ctiller ctiller merged commit 5f00f9c into master Aug 13, 2021
@ctiller ctiller deleted the revert-26965-fix_async_subchannel_destroy_bug branch August 13, 2021 02:24
Vignesh2208 pushed a commit to Vignesh2208/grpc that referenced this pull request Aug 20, 2021
…ve bugs related to async destruction of subchannels (grpc#26965)" (grpc#27004)

This reverts commit a35a9e1.
Vignesh2208 added a commit that referenced this pull request Aug 30, 2021
…r to solve bugs related to async destruction of subchannels (#26965)" (#27004)"

This reverts commit 5f00f9c.
Vignesh2208 added a commit that referenced this pull request Aug 30, 2021
…r to solve bugs related to async destruction of subchannels (#26965)" (#27004)" (#27191)

This reverts commit 5f00f9c.
jtattermusch added a commit that referenced this pull request Sep 3, 2021
…ctor/dtor to solve bugs related to async destruction of subchannels (#26965)" (#27004)" (#27191)"

This reverts commit b016729.
lidizheng pushed a commit to lidizheng/grpc that referenced this pull request Sep 23, 2021
…ve bugs related to async destruction of subchannels (grpc#26965)" (grpc#27004)

This reverts commit a35a9e1.
lidizheng pushed a commit to lidizheng/grpc that referenced this pull request Sep 23, 2021
…r to solve bugs related to async destruction of subchannels (grpc#26965)" (grpc#27004)" (grpc#27191)

This reverts commit 5f00f9c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants