Merged
Conversation
This reverts commit 840bcce.
ctiller
added
the
release notes: no
yashykt
approved these changes
Aug 13, 2021
Vignesh2208
pushed a commit
to Vignesh2208/grpc
that referenced
this pull request
Aug 20, 2021
* Revert "Revert "HPACK Table --> C++ (grpc#26851)" (grpc#26995)" This reverts commit 840bcce. * fix bad parsing of trailing === in binary metadata
lidizheng
pushed a commit
to lidizheng/grpc
that referenced
this pull request
Sep 23, 2021
* Revert "Revert "HPACK Table --> C++ (grpc#26851)" (grpc#26995)" This reverts commit 840bcce. * fix bad parsing of trailing === in binary metadata
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 840bcce.
Fixes are in 0700ff6
Long story short, we previously had no tests in OSS for handling of base64 binary metadata with trailing =='s