Fix resource leaks in xds test#26967
Merged
ericgribkoff merged 3 commits intogrpc:masterfrom Aug 11, 2021
Merged
Conversation
ericgribkoff
added
the
release notes: no
menghanl
approved these changes
Aug 11, 2021
ericgribkoff
added a commit
to ericgribkoff/grpc
that referenced
this pull request
Aug 11, 2021
* allow clean up of leaked cb backend services * auto-delete disk * yapf
ericgribkoff
added a commit
to ericgribkoff/grpc
that referenced
this pull request
Aug 11, 2021
* allow clean up of leaked cb backend services * auto-delete disk * yapf
ericgribkoff
added a commit
to ericgribkoff/grpc
that referenced
this pull request
Aug 11, 2021
* allow clean up of leaked cb backend services * auto-delete disk * yapf
ericgribkoff
added a commit
to ericgribkoff/grpc
that referenced
this pull request
Aug 11, 2021
* allow clean up of leaked cb backend services * auto-delete disk * yapf
ericgribkoff
added a commit
to ericgribkoff/grpc
that referenced
this pull request
Aug 11, 2021
* allow clean up of leaked cb backend services * auto-delete disk * yapf
ericgribkoff
added a commit
to ericgribkoff/grpc
that referenced
this pull request
Aug 11, 2021
* allow clean up of leaked cb backend services * auto-delete disk * yapf
ericgribkoff
added a commit
to ericgribkoff/grpc
that referenced
this pull request
Aug 11, 2021
* allow clean up of leaked cb backend services * auto-delete disk * yapf
ericgribkoff
added a commit
to ericgribkoff/grpc
that referenced
this pull request
Aug 11, 2021
* allow clean up of leaked cb backend services * auto-delete disk * yapf
ericgribkoff
added a commit
to ericgribkoff/grpc
that referenced
this pull request
Aug 11, 2021
* allow clean up of leaked cb backend services * auto-delete disk * yapf
ericgribkoff
added a commit
to ericgribkoff/grpc
that referenced
this pull request
Aug 11, 2021
* allow clean up of leaked cb backend services * auto-delete disk * yapf
ericgribkoff
added a commit
to ericgribkoff/grpc
that referenced
this pull request
Aug 11, 2021
* allow clean up of leaked cb backend services * auto-delete disk * yapf
This was referenced Aug 11, 2021
srini100
pushed a commit
that referenced
this pull request
Aug 12, 2021
srini100
pushed a commit
that referenced
this pull request
Aug 12, 2021
srini100
pushed a commit
that referenced
this pull request
Aug 12, 2021
srini100
pushed a commit
that referenced
this pull request
Aug 12, 2021
srini100
pushed a commit
that referenced
this pull request
Aug 12, 2021
srini100
pushed a commit
that referenced
this pull request
Aug 12, 2021
srini100
pushed a commit
that referenced
this pull request
Aug 12, 2021
srini100
pushed a commit
that referenced
this pull request
Aug 12, 2021
srini100
pushed a commit
that referenced
this pull request
Aug 12, 2021
srini100
pushed a commit
that referenced
this pull request
Aug 12, 2021
ericgribkoff
added a commit
that referenced
this pull request
Aug 12, 2021
Vignesh2208
pushed a commit
to Vignesh2208/grpc
that referenced
this pull request
Aug 20, 2021
* allow clean up of leaked cb backend services * auto-delete disk * yapf
lidizheng
pushed a commit
to lidizheng/grpc
that referenced
this pull request
Sep 23, 2021
* allow clean up of leaked cb backend services * auto-delete disk * yapf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The circuit breaking test creates its own backend services outside of the normal flow, which can potentially be leaked, preventing other GCP resources from being deleted; this adjusts the clean-up step for a subsequent run with
--use_existing_gcp_resourcesto be able to discover - and more importantly, delete - these leaked backend services. More context on b/192095168.The second commit ensures that disk images are deleted when the instance group is terminated, which is the default when creating via gcloud (https://cloud.google.com/sdk/gcloud/reference/compute/instance-templates/create#--boot-disk-auto-delete) but not when using the rest API (a regular clean-up job has been running to delete stranded disks, but this removes the leak altogether).