Adding grpc_init/grpc_shutdown to subchannel ctor/dtor to solve bugs related to async destruction of subchannels#26965
Merged
Vignesh2208 merged 2 commits intogrpc:masterfrom Aug 11, 2021
Conversation
…related to async destruction of subchannels
Vignesh2208
added
kind/bug
lang/core
release notes: no
yashykt
approved these changes
Aug 11, 2021
dennycd
pushed a commit
to dennycd/grpc
that referenced
this pull request
Aug 11, 2021
…related to async destruction of subchannels (grpc#26965) * Adding grpc_init/grpc_shutdown to subchannel ctor/dtor to solve bugs related to async destruction of subchannels * removing blank line
Vignesh2208
added a commit
to Vignesh2208/grpc
that referenced
this pull request
Aug 20, 2021
…related to async destruction of subchannels (grpc#26965) * Adding grpc_init/grpc_shutdown to subchannel ctor/dtor to solve bugs related to async destruction of subchannels * removing blank line
Vignesh2208
pushed a commit
to Vignesh2208/grpc
that referenced
this pull request
Aug 20, 2021
…ve bugs related to async destruction of subchannels (grpc#26965)" (grpc#27004) This reverts commit a35a9e1.
Vignesh2208
added a commit
that referenced
this pull request
Aug 30, 2021
jtattermusch
added a commit
that referenced
this pull request
Sep 3, 2021
lidizheng
pushed a commit
to lidizheng/grpc
that referenced
this pull request
Sep 23, 2021
…related to async destruction of subchannels (grpc#26965) * Adding grpc_init/grpc_shutdown to subchannel ctor/dtor to solve bugs related to async destruction of subchannels * removing blank line
lidizheng
pushed a commit
to lidizheng/grpc
that referenced
this pull request
Sep 23, 2021
…ve bugs related to async destruction of subchannels (grpc#26965)" (grpc#27004) This reverts commit a35a9e1.
lidizheng
pushed a commit
to lidizheng/grpc
that referenced
this pull request
Sep 23, 2021
…r to solve bugs related to async destruction of subchannels (grpc#26965)" (grpc#27004)" (grpc#27191) This reverts commit 5f00f9c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a grpc_init/grpc_shutdown to subchannel constructor and destructor to prevent grpc from being shutdown before the subchannel is destroyed. Subchannels can persist longer than channels because they maybe reused/shared among multiple channels. As a result the subchannel destruction happens asynchronously to channel destruction. If the last channel destruction triggers a grpc_shutdown before the last subchannel destruction, then there maybe race conditions
triggering segmentation faults. To prevent this issue, we call a grpc_init in the subchannel constructor and a grpc_shutdown in the subchannel destructor.
@yashykt