Added python deps installation to bazel/dockerfile#26952
Closed
veblush wants to merge 2 commits intogrpc:masterfrom
Closed
Added python deps installation to bazel/dockerfile#26952veblush wants to merge 2 commits intogrpc:masterfrom
veblush wants to merge 2 commits intogrpc:masterfrom
Conversation
veblush
added
lang/Python
area/build
release notes: no
veblush
requested review from
apolcyn,
jtattermusch and
nicolasnoble
as code owners
Contributor
I think this is unintentional. The Python xDS client and server target Python 3 only. I think this line must be pulling |
Contributor
|
As promised: #26953 |
Member
|
Solved in #26953. Thanks all for your help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revived the python2 package installation because the grpc_xds_python test needs them. Previously those were stripped because bazel can deal with the package installation by itself and it's not good for the maintenance to list unused packages with versions but it appears that some of them are still in use so let's revive them. But I should update the versions because old versions are not feasible to install anymore.