Experimental: add a roll-up semi-optional status action#26939
Merged
ctiller merged 24 commits intogrpc:masterfrom Aug 11, 2021
Merged
Experimental: add a roll-up semi-optional status action#26939ctiller merged 24 commits intogrpc:masterfrom
ctiller merged 24 commits intogrpc:masterfrom
Conversation
ctiller
added
the
release notes: no
Member
Author
|
This should be changed to cancel previous attempts, and wait until failure or success is determined |
gnossen
approved these changes
Aug 9, 2021
Vignesh2208
pushed a commit
to Vignesh2208/grpc
that referenced
this pull request
Aug 20, 2021
It check status on a pr, and when some set are successful it makes itself successful. If any that it's watching fail, it fails. If the force-merge label is applied, it succeeds. With the plan: we make EasyCLA and probably Sanity, and this one required statuses for merging (i.e. anything that should not be bypassed still gets verified by GitHub) We make every other status that we believe in (so everything but the Google3 presubmits because they're fresh?) something that this script verifies. That lets us do automerge (all things are passing) And if all things are not passing we can use human judgement and apply the force-merge label to bypass these checks... But importantly not the CLA check
lidizheng
pushed a commit
to lidizheng/grpc
that referenced
this pull request
Sep 23, 2021
It check status on a pr, and when some set are successful it makes itself successful. If any that it's watching fail, it fails. If the force-merge label is applied, it succeeds. With the plan: we make EasyCLA and probably Sanity, and this one required statuses for merging (i.e. anything that should not be bypassed still gets verified by GitHub) We make every other status that we believe in (so everything but the Google3 presubmits because they're fresh?) something that this script verifies. That lets us do automerge (all things are passing) And if all things are not passing we can use human judgement and apply the force-merge label to bypass these checks... But importantly not the CLA check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea here is to wait for some statuses to become ok before becoming ok ourselves... BUT allow a force-merge status to override that check.
We then make this action a required thing, and remove the required from the things it checks. Allows us to verify that required statuses are present, BUT ALSO override that requirement with a label (who's use will be logged and audit-able later).