Use stdcpp TLS on Fuchsia#26936
Merged
ctiller merged 1 commit intogrpc:masterfrom Aug 7, 2021
tamird:fuchsia-stdcpp-tls
Merged
Use stdcpp TLS on Fuchsia#26936ctiller merged 1 commit intogrpc:masterfrom tamird:fuchsia-stdcpp-tls
ctiller merged 1 commit intogrpc:masterfrom
tamird:fuchsia-stdcpp-tls
Conversation
There seems to be no reason this was using pthread apart from GPR_STDCPP_TLS not yet existing when the Fuchsia configs were created in https://fuchsia.googlesource.com/third_party/grpc/+/2dbaf2a.
ctiller
approved these changes
Aug 7, 2021
ctiller
added
kokoro:force-run
release notes: no
dennycd
pushed a commit
to dennycd/grpc
that referenced
this pull request
Aug 9, 2021
There seems to be no reason this was using pthread apart from GPR_STDCPP_TLS not yet existing when the Fuchsia configs were created in https://fuchsia.googlesource.com/third_party/grpc/+/2dbaf2a.
Vignesh2208
pushed a commit
to Vignesh2208/grpc
that referenced
this pull request
Aug 20, 2021
There seems to be no reason this was using pthread apart from GPR_STDCPP_TLS not yet existing when the Fuchsia configs were created in https://fuchsia.googlesource.com/third_party/grpc/+/2dbaf2a.
lidizheng
pushed a commit
to lidizheng/grpc
that referenced
this pull request
Sep 23, 2021
There seems to be no reason this was using pthread apart from GPR_STDCPP_TLS not yet existing when the Fuchsia configs were created in https://fuchsia.googlesource.com/third_party/grpc/+/2dbaf2a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be no reason this was using pthread apart from
GPR_STDCPP_TLS not yet existing when the Fuchsia configs were created in
https://fuchsia.googlesource.com/third_party/grpc/+/2dbaf2a.
We're seeing UBSAN trip on some tests in Fuchsia which appear to be loading an unaligned pointer from TLS. See https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=68325#c10.
@ctiller @brunowonka