Add thread safety annotations#26935
Merged
veblush merged 1 commit intogrpc:masterfrom Aug 10, 2021
tamird:thread-safety-annotations
Merged
Add thread safety annotations#26935veblush merged 1 commit intogrpc:masterfrom tamird:thread-safety-annotations
veblush merged 1 commit intogrpc:masterfrom
tamird:thread-safety-annotations
Conversation
ctiller
added
kokoro:force-run
release notes: no
Member
|
I think we've got a requirement of not running constructors before main for some customers... this may be a no-go. |
Contributor
Author
|
Okay - that part can be reverted. Can you confirm that? |
Member
|
Let's just go with https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables (I'm certain there are actual customers, I'm not digging any harder over the weekend) |
Contributor
Author
|
Done. |
Contributor
Author
|
I think this is ready to go. |
veblush
approved these changes
Aug 10, 2021
dennycd
pushed a commit
to dennycd/grpc
that referenced
this pull request
Aug 10, 2021
Vignesh2208
pushed a commit
to Vignesh2208/grpc
that referenced
this pull request
Aug 20, 2021
lidizheng
pushed a commit
to lidizheng/grpc
that referenced
this pull request
Sep 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're seeing UBSAN trip on some tests in Fuchsia - I found this while investigating that. See https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=68325.
@veblush @markdroth @ctiller @brunowonka