Merged
Conversation
Merged
Changes by create-pull-request action
Changes by create-pull-request action
Changes by create-pull-request action
ctiller
added
the
release notes: no
Changes by create-pull-request action
ananda1066
approved these changes
Aug 11, 2021
| @@ -47,31 +47,30 @@ | |||
| namespace grpc_core { | |||
| namespace promise_detail { | |||
Contributor
There was a problem hiding this comment.
One question - is there a reason this folder is called detail instead of internal? So promise_internal? Might be clearer naming
Member
Author
There was a problem hiding this comment.
I think just based on the tradition I found myself in most recently... I see detail and internal used for this fairly interchangeably regularly... I've also seen clutter and etc used in the same place. Tonight I kind of want to write gunk.
Vignesh2208
pushed a commit
to Vignesh2208/grpc
that referenced
this pull request
Aug 20, 2021
* Poll type for promises library * Library to talk about things that look like promises if you squint * Promise helpers, and basic type erasure * build * Changes to sync required for promise activities * sanitized * Automated change: Fix sanity tests * suppressions * try to fix windows failure * Automated change: Fix sanity tests Co-authored-by: ctiller <[email protected]>
lidizheng
pushed a commit
to lidizheng/grpc
that referenced
this pull request
Sep 23, 2021
* Poll type for promises library * Library to talk about things that look like promises if you squint * Promise helpers, and basic type erasure * build * Changes to sync required for promise activities * sanitized * Automated change: Fix sanity tests * suppressions * try to fix windows failure * Automated change: Fix sanity tests Co-authored-by: ctiller <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.