Library to talk about things that look like promises if you squint#26909
Merged
ctiller merged 11 commits intogrpc:masterfrom Aug 9, 2021
Merged
Library to talk about things that look like promises if you squint#26909ctiller merged 11 commits intogrpc:masterfrom
ctiller merged 11 commits intogrpc:masterfrom
Conversation
ctiller
added
the
release notes: no
Changes by create-pull-request action
ananda1066
reviewed
Aug 9, 2021
| // PromiseLike helps us deal with functors that return immediately. | ||
| // PromiseLike<F> if F returns Poll<T> is basically a no-op, where-as if F | ||
| // returns anything else, PromiseLike wraps the return of F to return a ready | ||
| // value immediately. |
Contributor
There was a problem hiding this comment.
I'm not sure I exactly understand what "wraps the return of F to return a ready value immediately" means? What does it do with the return value of F? And why is it called PromiseLike?
Member
Author
There was a problem hiding this comment.
Tried to write a better comment... wdyt?
Contributor
There was a problem hiding this comment.
Thanks! This is a lot more descriptive :)
ananda1066
approved these changes
Aug 9, 2021
dennycd
pushed a commit
to dennycd/grpc
that referenced
this pull request
Aug 10, 2021
…rpc#26909) * Poll type for promises library * Library to talk about things that look like promises if you squint * build * Changes to sync required for promise activities * sanitized * remove bad comment * better comment
Vignesh2208
pushed a commit
to Vignesh2208/grpc
that referenced
this pull request
Aug 20, 2021
…rpc#26909) * Poll type for promises library * Library to talk about things that look like promises if you squint * build * Changes to sync required for promise activities * sanitized * remove bad comment * better comment
lidizheng
pushed a commit
to lidizheng/grpc
that referenced
this pull request
Sep 23, 2021
…rpc#26909) * Poll type for promises library * Library to talk about things that look like promises if you squint * build * Changes to sync required for promise activities * sanitized * remove bad comment * better comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@yashykt