Import binder transport implementation#26901
Conversation
sifmelcara
added
the
release notes: no
sifmelcara
force-pushed
the
import-transport-source-2021-08-05
branch
3 times, most recently
from
f973c50 to
40b4893
Compare
src/core/ext/transport/binder/utils/transport_stream_receiver_impl.h
Outdated
Show resolved
Hide resolved
src/core/ext/transport/binder/utils/transport_stream_receiver.h
Outdated
Show resolved
Hide resolved
sifmelcara
force-pushed
the
import-transport-source-2021-08-05
branch
from
40b4893 to
af6bdd4
Compare
|
Hi Craig can you help take a look at our transport implementation ( Thanks! |
ctiller
left a comment
ctiller
left a comment
There was a problem hiding this comment.
Suspect this is too much for me to review thoroughly at once, and there are no tests.
The most I can say is it looks consistent with the rest of the codebase.
This commit imports the transport implementation from internal repository. (Some updates to existing wire_format code are also included) After this, we still need to import codes that creates channel, unit tests and e2e test to complete the transition to GitHub.
sifmelcara
force-pushed
the
import-transport-source-2021-08-05
branch
from
af6bdd4 to
aecea6c
Compare
|
Thanks! We do have gtests that covers the transport implementation in internal repository, but due to the difference between |
TaWeiTu
left a comment
TaWeiTu
left a comment
There was a problem hiding this comment.
This lacks some server-side connection features (done in internal repo) and there are known concurrency issue which I'm trying to fix. But for now I think this version works on our end-to-end tests (consists of different kinds of synchronized RPC calls).
Maybe I can try pushing a PR with tests so that it's easier to review?
Yeah we will keep syncing from internal repo for now.
Discussed offline |
This commit imports the transport implementation from internal repository. (Some updates to existing wire_format code are also included) After this, we still need to import codes that creates channel, unit tests and e2e test to complete the transition to GitHub.
This commit imports the transport implementation from internal repository. (Some updates to existing wire_format code are also included) After this, we still need to import codes that creates channel, unit tests and e2e test to complete the transition to GitHub.
This commit imports the transport implementation from internal repository. (Some updates to existing wire_format code are also included) After this, we still need to import codes that creates channel, unit tests and e2e test to complete the transition to GitHub.
3 participants
This commit imports the transport implementation from internal
repository. (Some updates to existing wire_format code are also included)
After this, we still need to import codes that creates channel, unit
tests and e2e test to complete the transition to GitHub.