Fix C# protoc plugin argument parsing#26896
Merged
apolcyn merged 1 commit intogrpc:masterfrom Aug 6, 2021
Merged
Conversation
stanley-cheung
approved these changes
Aug 5, 2021
apolcyn
added
the
release notes: no
This was referenced Aug 5, 2021
Contributor
|
ooops, sorry for introducing the issue & thanks for the fix. |
Vignesh2208
pushed a commit
to Vignesh2208/grpc
that referenced
this pull request
Aug 20, 2021
jtattermusch
pushed a commit
to jtattermusch/grpc
that referenced
this pull request
Aug 30, 2021
jtattermusch
added a commit
that referenced
this pull request
Aug 31, 2021
Co-authored-by: apolcyn <[email protected]>
lidizheng
pushed a commit
to lidizheng/grpc
that referenced
this pull request
Sep 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26819
#26162 caused a regression by adding the check for "file_suffix" in an if rather than
else if, causing theelseblock to always be hit in the case that a non-"file_suffix" option is passed in.