Conversation
GRPC_UV is alternative build for POSIX systems that already have a decalration of struct iovec
|
|
|
Thanks for the fix @kaegoorn . Are you planning to use the libuv build of gRPC-core? It hasn't been supported it in some time, and it would be good to know if folks still depend on it. |
|
To add to what @drfloob said, the libuv build was originally created to be used with the Node.js gRPC library, and that library uses version 1.24 of the core library and is also deprecated, so it will never use this change. |
|
We are using grpc and flatbuffer libraries in a commercial project that uses libuv and various other libuv based libraries without node.js and plan to continue using it in the future. We are using libuv 1.41 |
|
@kaegoorn with this fix in place, does gRPC-libuv work for you? If so, I have no great objection to merging it right now, but it's entirely unsupported. Even if the rest of your project uses libuv, I recommend against using the libuv-build of gRPC. |
drfloob
left a comment
There was a problem hiding this comment.
I'll merge this in, and plan to remove the libuv implementation.
|
interop cloud to prod: #26652 |
GRPC_UV is alternative build for POSIX systems that already have a decalration of struct iovec
|
@kaegoorn @markdroth @murgatroid99 I'll be removing the libuv build option this week. gRPC-core v1.40 will be the last to include a |
GRPC_UV is alternative build for POSIX systems that already have a decalration of struct iovec
GRPC_UV is alternative build for POSIX systems that already have a decalration of struct iovec
@drfloob