Skip to content

Fixed build with libuv#26807

Merged
drfloob merged 1 commit intogrpc:masterfrom
kaegoorn:kaegoorn-fix-uv-build
Aug 12, 2021
Merged

Fixed build with libuv#26807
drfloob merged 1 commit intogrpc:masterfrom
kaegoorn:kaegoorn-fix-uv-build

Conversation

@kaegoorn
Copy link
Copy Markdown
Contributor

GRPC_UV is alternative build for POSIX systems that already have a decalration of struct iovec

@drfloob

GRPC_UV is alternative build for POSIX systems that already have a decalration of struct iovec
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Jul 28, 2021

CLA Signed

The committers are authorized under a signed CLA.

@drfloob drfloob added area/core lang/core release notes: no Indicates if PR should not be in release notes labels Jul 28, 2021
@drfloob
Copy link
Copy Markdown
Member

drfloob commented Jul 28, 2021

Thanks for the fix @kaegoorn . Are you planning to use the libuv build of gRPC-core? It hasn't been supported it in some time, and it would be good to know if folks still depend on it.

@murgatroid99
Copy link
Copy Markdown
Member

To add to what @drfloob said, the libuv build was originally created to be used with the Node.js gRPC library, and that library uses version 1.24 of the core library and is also deprecated, so it will never use this change.

@kaegoorn
Copy link
Copy Markdown
Contributor Author

kaegoorn commented Jul 29, 2021

We are using grpc and flatbuffer libraries in a commercial project that uses libuv and various other libuv based libraries without node.js and plan to continue using it in the future. We are using libuv 1.41

@drfloob
Copy link
Copy Markdown
Member

drfloob commented Aug 2, 2021

@kaegoorn with this fix in place, does gRPC-libuv work for you? If so, I have no great objection to merging it right now, but it's entirely unsupported. Even if the rest of your project uses libuv, I recommend against using the libuv-build of gRPC.

Copy link
Copy Markdown
Member

@drfloob drfloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this in, and plan to remove the libuv implementation.

@drfloob
Copy link
Copy Markdown
Member

drfloob commented Aug 12, 2021

interop cloud to prod: #26652

@drfloob drfloob merged commit 5ce8ebc into grpc:master Aug 12, 2021
Vignesh2208 pushed a commit to Vignesh2208/grpc that referenced this pull request Aug 20, 2021
GRPC_UV is alternative build for POSIX systems that already have a decalration of struct iovec
@drfloob
Copy link
Copy Markdown
Member

drfloob commented Aug 30, 2021

@kaegoorn @markdroth @murgatroid99

I'll be removing the libuv build option this week. gRPC-core v1.40 will be the last to include a GRPC_UV build option.

lidizheng pushed a commit to lidizheng/grpc that referenced this pull request Sep 23, 2021
GRPC_UV is alternative build for POSIX systems that already have a decalration of struct iovec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core lang/core release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants