Annotate copied Content native lib items with package id to enable customization#26725
Merged
jtattermusch merged 1 commit intogrpc:masterfrom Sep 3, 2021
Merged
Annotate copied Content native lib items with package id to enable customization#26725jtattermusch merged 1 commit intogrpc:masterfrom
jtattermusch merged 1 commit intogrpc:masterfrom
Conversation
…stomization Add `%(NuGetPackageId)` as is standard procedure for nuget package-provided assets, so that other MSBuild targets can act on items contributed by Grpc.Core as needed, for example, in Pack scenarios. Fixes grpc#26724
|
|
jtattermusch
added
lang/C#
release notes: yes
Contributor
|
Adhoc distribtest run: macos artifact build consistently hits infrastructure problems (the build is timing out), so I'm unable to get a green build. That problem is orthogonal to this PR, so I'm simply going to merge and check the greenness of distribtests on the continous run afterwards. |
jtattermusch
approved these changes
Aug 27, 2021
Contributor
jtattermusch
left a comment
jtattermusch
left a comment
There was a problem hiding this comment.
LGTM once the tests pass.
Contributor
|
@apolcyn please add another LGTM. |
apolcyn
approved these changes
Sep 2, 2021
copybara-service
Bot
added
the
imported
Contributor
|
FTR I checked the distribtests results after merging and they were green. |
lidizheng
pushed a commit
to lidizheng/grpc
that referenced
this pull request
Sep 23, 2021
…stomization (grpc#26725) Add `%(NuGetPackageId)` as is standard procedure for nuget package-provided assets, so that other MSBuild targets can act on items contributed by Grpc.Core as needed, for example, in Pack scenarios. Fixes grpc#26724
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
%(NuGetPackageId)as is standard procedure for nuget package-provided assets,so that other MSBuild targets can act on items contributed by Grpc.Core as needed, for
example, in Pack scenarios.
Fixes #26724
@nicolasnoble