Allow gRPC-C++ to pod install on Linux#26630
Allow gRPC-C++ to pod install on Linux#26630morganchen12 wants to merge 1 commit intogrpc:masterfrom
Conversation
jtattermusch
left a comment
jtattermusch
left a comment
There was a problem hiding this comment.
I might be missing the context, but why would you need to install gRPC C++ pod on Linux?
Also, you're mentioning that builds still can't run on linux, so I'm not sure what's the deployment model you're suggesting.
| end | ||
|
|
||
| s.prepare_command = <<-END_OF_COMMAND | ||
| if [[ "$(uname)" == "Darwin" ]]; then |
There was a problem hiding this comment.
I don't understand why this is necessary and why it's the correct solution. Mind explaining in a bit more detail?
There was a problem hiding this comment.
Firebase uses Cloud's repository gardener, which runs jobs on Linux kokoro to update dependencies on open-source repositories. The script we run uses CocoaPods to actually generate the dependency updates via pod update, which invokes pod install, which currently fails for gRPC-C++ due to differences in Linux and macOS sed and base64.
This PR skips the script portion of gRPC-CC++'s pod install on Linux systems to allow the installation to succeed.
There was a problem hiding this comment.
Thanks for the PR @morganchen12 . we should probably avoid branching on specific platforms, and instead find out what's causing the sed errors and use a common denominator syntax that would work for both (Darwin/BSD sed & Linux/GNU sed) if possible. See some comparison here
There was a problem hiding this comment.
You might want to modify the template podspec first, and then re-generate these files instead (https://github.com/grpc/grpc/blob/master/templates/gRPC-C%2B%2B.podspec.template#L3-L6).
|
Closing in favor of #27300. |
4 participants
Fixes firebase/quickstart-ios#1099. Builds still cannot be run on Linux since
xcodebuildis not available, so messing up the headers is ok.